2017-06-13 11:57:12

by Grzegorz Kołodziejczyk

Subject: [PATCH BlueZ] shared/gatt-client: Correct att err variable

According to Core specification version 5.0 (Vol 3, Part F, 3.4.1.1)
error code size is one byte.
---
src/shared/gatt-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
index 58ab0b8..fbf90ff 100644
--- a/src/shared/gatt-client.c
+++ b/src/shared/gatt-client.c
@@ -1239,7 +1239,7 @@ static void enable_ccc_callback(uint8_t opcode, const void *pdu,
uint16_t length, void *user_data)
{
struct notify_data *notify_data = user_data;
- uint16_t att_ecode;
+ uint8_t att_ecode;

assert(notify_data->chrc->ccc_write_id);

--
2.9.4

2017-06-19 08:25:01

by Luiz Augusto von Dentz

Subject: Re: [PATCH BlueZ] shared/gatt-client: Correct att err variable

Hi Grzegorz,

On Tue, Jun 13, 2017 at 2:57 PM, Grzegorz Kolodziejczyk
<[email protected]> wrote:
> According to Core specification version 5.0 (Vol 3, Part F, 3.4.1.1)
> error code size is one byte.
> ---
> src/shared/gatt-client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
> index 58ab0b8..fbf90ff 100644
> --- a/src/shared/gatt-client.c
> +++ b/src/shared/gatt-client.c
> @@ -1239,7 +1239,7 @@ static void enable_ccc_callback(uint8_t opcode, const void *pdu,
> uint16_t length, void *user_data)
> {
> struct notify_data *notify_data = user_data;
> - uint16_t att_ecode;
> + uint8_t att_ecode;
>
> assert(notify_data->chrc->ccc_write_id);
>
> --
> 2.9.4

Applied, thanks.

--
Luiz Augusto von Dentz