2017-07-26 08:16:40

by Frédéric Dalleau

Subject: [PATCH v2 0/2] Fixes in monitor mesh

Hi, I came across those two things, so here are some patches.

v2 updates the format to 8.8x.

Regards,

Frédéric Dalleau (2):
monitor: Fix OOB information bit in mesh oob table
monitor: Format URI hash using 8 hex digits

monitor/packet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--
2.11.0

2017-07-27 14:23:57

by Luiz Augusto von Dentz

Subject: Re: [PATCH v2 0/2] Fixes in monitor mesh

Hi Fr=C3=A9d=C3=A9ric,

On Wed, Jul 26, 2017 at 11:16 AM, Fr=C3=A9d=C3=A9ric Dalleau
<[email protected]> wrote:
> Hi, I came across those two things, so here are some patches.
>
> v2 updates the format to 8.8x.
>
> Regards,
>
> Fr=C3=A9d=C3=A9ric Dalleau (2):
> monitor: Fix OOB information bit in mesh oob table
> monitor: Format URI hash using 8 hex digits
>
> monitor/packet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.11.0

Applied, thanks.

--=20
Luiz Augusto von Dentz

2017-07-26 08:16:42

by Frédéric Dalleau

Subject: [PATCH v2 2/2] monitor: Format URI hash using 8 hex digits

URI hash is a 32 bits value.
---
monitor/packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index f72fcab6a..39823691f 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -3551,7 +3551,7 @@ static void print_mesh_beacon(const uint8_t *data, uint8_t len)
break;
}

- print_field(" URI Hash: 0x%4.4x", get_be32(data + 19));
+ print_field(" URI Hash: 0x%8.8x", get_be32(data + 19));
packet_hexdump(data + 23, len - 23);
break;
case 0x01:
--
2.11.0

2017-07-26 08:16:41

by Frédéric Dalleau

Subject: [PATCH v2 1/2] monitor: Fix OOB information bit in mesh oob table

The bit 15 should be used for 'On device'.
---
monitor/packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 387be1dcb..f72fcab6a 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -3514,7 +3514,7 @@ static const struct {
{ 12, "Inside box" },
{ 13, "On piece of paper" },
{ 14, "Inside manual" },
- { 14, "On device" },
+ { 15, "On device" },
{ }
};

--
2.11.0