2020-12-28 06:25:23

by Yun-hao Chung

Subject: [Bluez PATCH v1] shared/gatt-client: Fix GATT client attribute read with offset

bluez always replies the whole value despite a user specify the offset.
This patch fixes the issue.

Reviewed-by: [email protected]
---

src/gatt-client.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/gatt-client.c b/src/gatt-client.c
index 0cf5324ffa46..bec6e1ec049e 100644
--- a/src/gatt-client.c
+++ b/src/gatt-client.c
@@ -368,7 +368,8 @@ static void desc_read_cb(bool success, uint8_t att_ecode,
}

/* Read the stored data from db */
- if (!gatt_db_attribute_read(desc->attr, 0, 0, NULL, read_op_cb, op)) {
+ if (!gatt_db_attribute_read(desc->attr, op->offset, 0, NULL, read_op_cb,
+ op)) {
error("Failed to read database");
att_ecode = BT_ATT_ERROR_UNLIKELY;
goto fail;
@@ -906,7 +907,8 @@ static void chrc_read_cb(bool success, uint8_t att_ecode, const uint8_t *value,
}

/* Read the stored data from db */
- if (!gatt_db_attribute_read(chrc->attr, 0, 0, NULL, read_op_cb, op)) {
+ if (!gatt_db_attribute_read(chrc->attr, op->offset, 0, NULL, read_op_cb,
+ op)) {
error("Failed to read database");
att_ecode = BT_ATT_ERROR_UNLIKELY;
goto fail;
--
2.29.2.729.g45daf8777d-goog

2020-12-28 06:48:43

by bluez.test.bot

Subject: RE: [Bluez,v1] shared/gatt-client: Fix GATT client attribute read with offset

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=406657

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth

2021-06-28 23:39:47

by Luiz Augusto von Dentz

Subject: Re: [Bluez PATCH v1] shared/gatt-client: Fix GATT client attribute read with offset

Hi Howard,

On Mon, Jun 28, 2021 at 4:57 AM Yun-hao Chung <[email protected]> wrote:
>
> Hi,
>
> Can we get a reply on this patch?
>
> Thanks,
> Howard
>
> On Mon, Dec 28, 2020 at 2:22 PM Howard Chung <[email protected]> wrote:
>>
>> bluez always replies the whole value despite a user specify the offset.
>> This patch fixes the issue.
>>
>> Reviewed-by: [email protected]
>> ---
>>
>> src/gatt-client.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/gatt-client.c b/src/gatt-client.c
>> index 0cf5324ffa46..bec6e1ec049e 100644
>> --- a/src/gatt-client.c
>> +++ b/src/gatt-client.c
>> @@ -368,7 +368,8 @@ static void desc_read_cb(bool success, uint8_t att_ecode,
>> }
>>
>> /* Read the stored data from db */
>> - if (!gatt_db_attribute_read(desc->attr, 0, 0, NULL, read_op_cb, op)) {
>> + if (!gatt_db_attribute_read(desc->attr, op->offset, 0, NULL, read_op_cb,
>> + op)) {
>> error("Failed to read database");
>> att_ecode = BT_ATT_ERROR_UNLIKELY;
>> goto fail;
>> @@ -906,7 +907,8 @@ static void chrc_read_cb(bool success, uint8_t att_ecode, const uint8_t *value,
>> }
>>
>> /* Read the stored data from db */
>> - if (!gatt_db_attribute_read(chrc->attr, 0, 0, NULL, read_op_cb, op)) {
>> + if (!gatt_db_attribute_read(chrc->attr, op->offset, 0, NULL, read_op_cb,
>> + op)) {
>> error("Failed to read database");
>> att_ecode = BT_ATT_ERROR_UNLIKELY;
>> goto fail;
>> --
>> 2.29.2.729.g45daf8777d-goog

Applied, thanks.

--
Luiz Augusto von Dentz