Hi,
so when I try to connect a LE L2CAP connection to a device that does not exist and then abort it will not have reached the timeout, I get this:
< HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
Address type: Public (0x00)
Address: 11:22:33:44:55:66 (OUI 11-22-33)
> HCI Event: Command Complete (0x0e) plen 4
LE Add Device To White List (0x08|0x0011) ncmd 1
Status: Success (0x00)
< HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
Type: Passive (0x00)
Interval: 60.000 msec (0x0060)
Window: 30.000 msec (0x0030)
Own address type: Public (0x00)
Filter policy: Ignore not in white list (0x01)
> HCI Event: Command Complete (0x0e) plen 4
LE Set Scan Parameters (0x08|0x000b) ncmd 1
Status: Success (0x00)
< HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
Scanning: Enabled (0x01)
Filter duplicates: Enabled (0x01)
> HCI Event: Command Complete (0x0e) plen 4
LE Set Scan Enable (0x08|0x000c) ncmd 1
Status: Success (0x00)
< HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
Scanning: Disabled (0x00)
Filter duplicates: Disabled (0x00)
> HCI Event: Command Complete (0x0e) plen 4
LE Set Scan Enable (0x08|0x000c) ncmd 1
Status: Success (0x00)
< HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
Scanning: Disabled (0x00)
Filter duplicates: Disabled (0x00)
> HCI Event: Command Complete (0x0e) plen 4
LE Set Scan Enable (0x08|0x000c) ncmd 1
Status: Command Disallowed (0x0c)
Notice the two attempts for disabling scanning. We should not do that. This is clearly a bug. This can be easily reproduced with latest bluetooth-next and this command:
l2test -V le_public -n 11:22:33:44:55:66
The same happens when you are waiting for the socket connect timeout. The scanning disable command is sent twice.
I also had a case where the disabling of the scanning is not sent at all and the controller kept scanning. However for that one, I do not have an easy way to reproduce it. But it is essentially the same case, you close the socket / application before the connection has been established.
Regards
Marcel
Hi Jakub,
>>>>> so when I try to connect a LE L2CAP connection to a device that does not exist and then abort it will not have reached the timeout, I get this:
>>>>>
>>>>> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
>>>>> Address type: Public (0x00)
>>>>> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Add Device To White List (0x08|0x0011) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
>>>>> Type: Passive (0x00)
>>>>> Interval: 60.000 msec (0x0060)
>>>>> Window: 30.000 msec (0x0030)
>>>>> Own address type: Public (0x00)
>>>>> Filter policy: Ignore not in white list (0x01)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Parameters (0x08|0x000b) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>> Scanning: Enabled (0x01)
>>>>> Filter duplicates: Enabled (0x01)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>> Scanning: Disabled (0x00)
>>>>> Filter duplicates: Disabled (0x00)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>> Scanning: Disabled (0x00)
>>>>> Filter duplicates: Disabled (0x00)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>> Status: Command Disallowed (0x0c)
>>>>>
>>>>> Notice the two attempts for disabling scanning. We should not do that. This is clearly a bug. This can be easily reproduced with latest bluetooth-next and this command:
>>>>>
>>>>> l2test -V le_public -n 11:22:33:44:55:66
>>>>>
>>>>> The same happens when you are waiting for the socket connect timeout. The scanning disable command is sent twice.
>>>>>
>>>>> I also had a case where the disabling of the scanning is not sent at all and the controller kept scanning. However for that one, I do not have an easy way to reproduce it. But it is essentially the same case, you close the socket / application before the connection has been established.
>>>>
>>>> in addition when a connect() for LE L2CAP socket call times out, we get an invalid module reference count.
>>>>
>>>> bluetooth 532480 1
>>>> rfkill 24576 1 bluetooth
>>>>
>>>> I see it left with an extra reference count. This is pretty bad and shows that something is clearly wrong.
>>>
>>> please also look into this. We are not clearing the reference count correctly when aborting a connection attempt while still in scanning phase.
>>>
>> Ok, I'll look into that
>
> So I think that patch I've send fixed that.
> I run tools/l2test -V le_public -n 11:22:33:44:55:66
> and kill it, or wait for timeout, and reference count always drops
> down to same initial value as before running that command.
I applied both patches (you are forgetting --signoff on these) and the module reference count is still out of balance. Try to unload all modules. You will see that bluetooth.ko is left with a reference count.
Regards
Marcel
Hi Marcel,
On Fri, Oct 9, 2015 at 2:44 PM, Marcel Holtmann <[email protected]> wrote=
:
> Hi Jakub,
>
>>>>>> so when I try to connect a LE L2CAP connection to a device that does=
not exist and then abort it will not have reached the timeout, I get this:
>>>>>>
>>>>>> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
>>>>>> Address type: Public (0x00)
>>>>>> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>>> LE Add Device To White List (0x08|0x0011) ncmd 1
>>>>>> Status: Success (0x00)
>>>>>> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
>>>>>> Type: Passive (0x00)
>>>>>> Interval: 60.000 msec (0x0060)
>>>>>> Window: 30.000 msec (0x0030)
>>>>>> Own address type: Public (0x00)
>>>>>> Filter policy: Ignore not in white list (0x01)
>>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>>> LE Set Scan Parameters (0x08|0x000b) ncmd 1
>>>>>> Status: Success (0x00)
>>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>>> Scanning: Enabled (0x01)
>>>>>> Filter duplicates: Enabled (0x01)
>>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>>> Status: Success (0x00)
>>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>>> Scanning: Disabled (0x00)
>>>>>> Filter duplicates: Disabled (0x00)
>>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>>> Status: Success (0x00)
>>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>>> Scanning: Disabled (0x00)
>>>>>> Filter duplicates: Disabled (0x00)
>>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>>> Status: Command Disallowed (0x0c)
>>>>>>
>>>>>> Notice the two attempts for disabling scanning. We should not do tha=
t. This is clearly a bug. This can be easily reproduced with latest bluetoo=
th-next and this command:
>>>>>>
>>>>>> l2test -V le_public -n 11:22:33:44:55:66
>>>>>>
>>>>>> The same happens when you are waiting for the socket connect timeout=
. The scanning disable command is sent twice.
>>>>>>
>>>>>> I also had a case where the disabling of the scanning is not sent at=
all and the controller kept scanning. However for that one, I do not have =
an easy way to reproduce it. But it is essentially the same case, you close=
the socket / application before the connection has been established.
>>>>>
>>>>> in addition when a connect() for LE L2CAP socket call times out, we g=
et an invalid module reference count.
>>>>>
>>>>> bluetooth 532480 1
>>>>> rfkill 24576 1 bluetooth
>>>>>
>>>>> I see it left with an extra reference count. This is pretty bad and s=
hows that something is clearly wrong.
>>>>
>>>> please also look into this. We are not clearing the reference count co=
rrectly when aborting a connection attempt while still in scanning phase.
>>>>
>>> Ok, I'll look into that
>>
>> So I think that patch I've send fixed that.
>> I run tools/l2test -V le_public -n 11:22:33:44:55:66
>> and kill it, or wait for timeout, and reference count always drops
>> down to same initial value as before running that command.
>
> have you tried to unload all modules. Including bluetooth.ko?
>
Ok, now I see the problem :) thanks.
> Regards
>
> Marcel
>
Hi Jakub,
>>>>> so when I try to connect a LE L2CAP connection to a device that does not exist and then abort it will not have reached the timeout, I get this:
>>>>>
>>>>> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
>>>>> Address type: Public (0x00)
>>>>> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Add Device To White List (0x08|0x0011) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
>>>>> Type: Passive (0x00)
>>>>> Interval: 60.000 msec (0x0060)
>>>>> Window: 30.000 msec (0x0030)
>>>>> Own address type: Public (0x00)
>>>>> Filter policy: Ignore not in white list (0x01)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Parameters (0x08|0x000b) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>> Scanning: Enabled (0x01)
>>>>> Filter duplicates: Enabled (0x01)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>> Scanning: Disabled (0x00)
>>>>> Filter duplicates: Disabled (0x00)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>> Status: Success (0x00)
>>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>>> Scanning: Disabled (0x00)
>>>>> Filter duplicates: Disabled (0x00)
>>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>>> Status: Command Disallowed (0x0c)
>>>>>
>>>>> Notice the two attempts for disabling scanning. We should not do that. This is clearly a bug. This can be easily reproduced with latest bluetooth-next and this command:
>>>>>
>>>>> l2test -V le_public -n 11:22:33:44:55:66
>>>>>
>>>>> The same happens when you are waiting for the socket connect timeout. The scanning disable command is sent twice.
>>>>>
>>>>> I also had a case where the disabling of the scanning is not sent at all and the controller kept scanning. However for that one, I do not have an easy way to reproduce it. But it is essentially the same case, you close the socket / application before the connection has been established.
>>>>
>>>> in addition when a connect() for LE L2CAP socket call times out, we get an invalid module reference count.
>>>>
>>>> bluetooth 532480 1
>>>> rfkill 24576 1 bluetooth
>>>>
>>>> I see it left with an extra reference count. This is pretty bad and shows that something is clearly wrong.
>>>
>>> please also look into this. We are not clearing the reference count correctly when aborting a connection attempt while still in scanning phase.
>>>
>> Ok, I'll look into that
>
> So I think that patch I've send fixed that.
> I run tools/l2test -V le_public -n 11:22:33:44:55:66
> and kill it, or wait for timeout, and reference count always drops
> down to same initial value as before running that command.
have you tried to unload all modules. Including bluetooth.ko?
Regards
Marcel
Hi Marcel,
On Fri, Oct 9, 2015 at 12:48 PM, Jakub Pawlowski <[email protected]> wr=
ote:
> On Fri, Oct 9, 2015 at 11:48 AM, Marcel Holtmann <[email protected]> wr=
ote:
>> Hi Jakub,
>>
>>>> so when I try to connect a LE L2CAP connection to a device that does n=
ot exist and then abort it will not have reached the timeout, I get this:
>>>>
>>>> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
>>>> Address type: Public (0x00)
>>>> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>> LE Add Device To White List (0x08|0x0011) ncmd 1
>>>> Status: Success (0x00)
>>>> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
>>>> Type: Passive (0x00)
>>>> Interval: 60.000 msec (0x0060)
>>>> Window: 30.000 msec (0x0030)
>>>> Own address type: Public (0x00)
>>>> Filter policy: Ignore not in white list (0x01)
>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>> LE Set Scan Parameters (0x08|0x000b) ncmd 1
>>>> Status: Success (0x00)
>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>> Scanning: Enabled (0x01)
>>>> Filter duplicates: Enabled (0x01)
>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>> Status: Success (0x00)
>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>> Scanning: Disabled (0x00)
>>>> Filter duplicates: Disabled (0x00)
>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>> Status: Success (0x00)
>>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>>> Scanning: Disabled (0x00)
>>>> Filter duplicates: Disabled (0x00)
>>>>> HCI Event: Command Complete (0x0e) plen 4
>>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>>> Status: Command Disallowed (0x0c)
>>>>
>>>> Notice the two attempts for disabling scanning. We should not do that.=
This is clearly a bug. This can be easily reproduced with latest bluetooth=
-next and this command:
>>>>
>>>> l2test -V le_public -n 11:22:33:44:55:66
>>>>
>>>> The same happens when you are waiting for the socket connect timeout. =
The scanning disable command is sent twice.
>>>>
>>>> I also had a case where the disabling of the scanning is not sent at a=
ll and the controller kept scanning. However for that one, I do not have an=
easy way to reproduce it. But it is essentially the same case, you close t=
he socket / application before the connection has been established.
>>>
>>> in addition when a connect() for LE L2CAP socket call times out, we get=
an invalid module reference count.
>>>
>>> bluetooth 532480 1
>>> rfkill 24576 1 bluetooth
>>>
>>> I see it left with an extra reference count. This is pretty bad and sho=
ws that something is clearly wrong.
>>
>> please also look into this. We are not clearing the reference count corr=
ectly when aborting a connection attempt while still in scanning phase.
>>
> Ok, I'll look into that
So I think that patch I've send fixed that.
I run tools/l2test -V le_public -n 11:22:33:44:55:66
and kill it, or wait for timeout, and reference count always drops
down to same initial value as before running that command.
>> Regards
>>
>> Marcel
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bluetoot=
h" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 9, 2015 at 11:48 AM, Marcel Holtmann <[email protected]> wrot=
e:
> Hi Jakub,
>
>>> so when I try to connect a LE L2CAP connection to a device that does no=
t exist and then abort it will not have reached the timeout, I get this:
>>>
>>> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
>>> Address type: Public (0x00)
>>> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>>>> HCI Event: Command Complete (0x0e) plen 4
>>> LE Add Device To White List (0x08|0x0011) ncmd 1
>>> Status: Success (0x00)
>>> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
>>> Type: Passive (0x00)
>>> Interval: 60.000 msec (0x0060)
>>> Window: 30.000 msec (0x0030)
>>> Own address type: Public (0x00)
>>> Filter policy: Ignore not in white list (0x01)
>>>> HCI Event: Command Complete (0x0e) plen 4
>>> LE Set Scan Parameters (0x08|0x000b) ncmd 1
>>> Status: Success (0x00)
>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>> Scanning: Enabled (0x01)
>>> Filter duplicates: Enabled (0x01)
>>>> HCI Event: Command Complete (0x0e) plen 4
>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>> Status: Success (0x00)
>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>> Scanning: Disabled (0x00)
>>> Filter duplicates: Disabled (0x00)
>>>> HCI Event: Command Complete (0x0e) plen 4
>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>> Status: Success (0x00)
>>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>>> Scanning: Disabled (0x00)
>>> Filter duplicates: Disabled (0x00)
>>>> HCI Event: Command Complete (0x0e) plen 4
>>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>>> Status: Command Disallowed (0x0c)
>>>
>>> Notice the two attempts for disabling scanning. We should not do that. =
This is clearly a bug. This can be easily reproduced with latest bluetooth-=
next and this command:
>>>
>>> l2test -V le_public -n 11:22:33:44:55:66
>>>
>>> The same happens when you are waiting for the socket connect timeout. T=
he scanning disable command is sent twice.
>>>
>>> I also had a case where the disabling of the scanning is not sent at al=
l and the controller kept scanning. However for that one, I do not have an =
easy way to reproduce it. But it is essentially the same case, you close th=
e socket / application before the connection has been established.
>>
>> in addition when a connect() for LE L2CAP socket call times out, we get =
an invalid module reference count.
>>
>> bluetooth 532480 1
>> rfkill 24576 1 bluetooth
>>
>> I see it left with an extra reference count. This is pretty bad and show=
s that something is clearly wrong.
>
> please also look into this. We are not clearing the reference count corre=
ctly when aborting a connection attempt while still in scanning phase.
>
Ok, I'll look into that
> Regards
>
> Marcel
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth=
" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jakub,
>> so when I try to connect a LE L2CAP connection to a device that does not exist and then abort it will not have reached the timeout, I get this:
>>
>> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
>> Address type: Public (0x00)
>> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Add Device To White List (0x08|0x0011) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
>> Type: Passive (0x00)
>> Interval: 60.000 msec (0x0060)
>> Window: 30.000 msec (0x0030)
>> Own address type: Public (0x00)
>> Filter policy: Ignore not in white list (0x01)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Parameters (0x08|0x000b) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>> Scanning: Enabled (0x01)
>> Filter duplicates: Enabled (0x01)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>> Scanning: Disabled (0x00)
>> Filter duplicates: Disabled (0x00)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>> Scanning: Disabled (0x00)
>> Filter duplicates: Disabled (0x00)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>> Status: Command Disallowed (0x0c)
>>
>> Notice the two attempts for disabling scanning. We should not do that. This is clearly a bug. This can be easily reproduced with latest bluetooth-next and this command:
>>
>> l2test -V le_public -n 11:22:33:44:55:66
>>
>> The same happens when you are waiting for the socket connect timeout. The scanning disable command is sent twice.
>>
>> I also had a case where the disabling of the scanning is not sent at all and the controller kept scanning. However for that one, I do not have an easy way to reproduce it. But it is essentially the same case, you close the socket / application before the connection has been established.
>
> in addition when a connect() for LE L2CAP socket call times out, we get an invalid module reference count.
>
> bluetooth 532480 1
> rfkill 24576 1 bluetooth
>
> I see it left with an extra reference count. This is pretty bad and shows that something is clearly wrong.
please also look into this. We are not clearing the reference count correctly when aborting a connection attempt while still in scanning phase.
Regards
Marcel
Hi,
On Fri, Oct 9, 2015 at 8:32 AM, Marcel Holtmann <[email protected]> wrote=
:
> Hi,
>
>> so when I try to connect a LE L2CAP connection to a device that does not=
exist and then abort it will not have reached the timeout, I get this:
>>
>> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
>> Address type: Public (0x00)
>> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Add Device To White List (0x08|0x0011) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
>> Type: Passive (0x00)
>> Interval: 60.000 msec (0x0060)
>> Window: 30.000 msec (0x0030)
>> Own address type: Public (0x00)
>> Filter policy: Ignore not in white list (0x01)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Parameters (0x08|0x000b) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>> Scanning: Enabled (0x01)
>> Filter duplicates: Enabled (0x01)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>> Scanning: Disabled (0x00)
>> Filter duplicates: Disabled (0x00)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>> Status: Success (0x00)
>> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
>> Scanning: Disabled (0x00)
>> Filter duplicates: Disabled (0x00)
>>> HCI Event: Command Complete (0x0e) plen 4
>> LE Set Scan Enable (0x08|0x000c) ncmd 1
>> Status: Command Disallowed (0x0c)
>>
>> Notice the two attempts for disabling scanning. We should not do that. T=
his is clearly a bug. This can be easily reproduced with latest bluetooth-n=
ext and this command:
>>
>> l2test -V le_public -n 11:22:33:44:55:66
>>
>> The same happens when you are waiting for the socket connect timeout. Th=
e scanning disable command is sent twice.
I think my code is causing that, will send patch with fix in few minutes...
>>
>> I also had a case where the disabling of the scanning is not sent at all=
and the controller kept scanning. However for that one, I do not have an e=
asy way to reproduce it. But it is essentially the same case, you close the=
socket / application before the connection has been established.
>
> in addition when a connect() for LE L2CAP socket call times out, we get a=
n invalid module reference count.
>
> bluetooth 532480 1
> rfkill 24576 1 bluetooth
>
> I see it left with an extra reference count. This is pretty bad and shows=
that something is clearly wrong.
>
> Regards
>
> Marcel
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth=
" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
> so when I try to connect a LE L2CAP connection to a device that does not exist and then abort it will not have reached the timeout, I get this:
>
> < HCI Command: LE Add Device To White List (0x08|0x0011) plen 7
> Address type: Public (0x00)
> Address: 11:22:33:44:55:66 (OUI 11-22-33)
>> HCI Event: Command Complete (0x0e) plen 4
> LE Add Device To White List (0x08|0x0011) ncmd 1
> Status: Success (0x00)
> < HCI Command: LE Set Scan Parameters (0x08|0x000b) plen 7
> Type: Passive (0x00)
> Interval: 60.000 msec (0x0060)
> Window: 30.000 msec (0x0030)
> Own address type: Public (0x00)
> Filter policy: Ignore not in white list (0x01)
>> HCI Event: Command Complete (0x0e) plen 4
> LE Set Scan Parameters (0x08|0x000b) ncmd 1
> Status: Success (0x00)
> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
> Scanning: Enabled (0x01)
> Filter duplicates: Enabled (0x01)
>> HCI Event: Command Complete (0x0e) plen 4
> LE Set Scan Enable (0x08|0x000c) ncmd 1
> Status: Success (0x00)
> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
> Scanning: Disabled (0x00)
> Filter duplicates: Disabled (0x00)
>> HCI Event: Command Complete (0x0e) plen 4
> LE Set Scan Enable (0x08|0x000c) ncmd 1
> Status: Success (0x00)
> < HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2
> Scanning: Disabled (0x00)
> Filter duplicates: Disabled (0x00)
>> HCI Event: Command Complete (0x0e) plen 4
> LE Set Scan Enable (0x08|0x000c) ncmd 1
> Status: Command Disallowed (0x0c)
>
> Notice the two attempts for disabling scanning. We should not do that. This is clearly a bug. This can be easily reproduced with latest bluetooth-next and this command:
>
> l2test -V le_public -n 11:22:33:44:55:66
>
> The same happens when you are waiting for the socket connect timeout. The scanning disable command is sent twice.
>
> I also had a case where the disabling of the scanning is not sent at all and the controller kept scanning. However for that one, I do not have an easy way to reproduce it. But it is essentially the same case, you close the socket / application before the connection has been established.
in addition when a connect() for LE L2CAP socket call times out, we get an invalid module reference count.
bluetooth 532480 1
rfkill 24576 1 bluetooth
I see it left with an extra reference count. This is pretty bad and shows that something is clearly wrong.
Regards
Marcel