2015-01-09 03:47:19

by Gigi Joseph

Subject: [PATCH 3/6] btwilink: add minimal device tree support

Add minimal device tree support to the btwilink driver that is used
for binding bluetooth with the ti-st shared transport driver.

Signed-off-by: Eyal Reizer <[email protected]>
Signed-off-by: bvijay <[email protected]>
Signed-off-by: Gigi Joseph <[email protected]>
---
drivers/bluetooth/btwilink.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
index 55c135b..95adec3 100644
--- a/drivers/bluetooth/btwilink.c
+++ b/drivers/bluetooth/btwilink.c
@@ -30,6 +30,7 @@

#include <linux/ti_wilink_st.h>
#include <linux/module.h>
+#include <linux/of.h>

/* Bluetooth Driver Version */
#define VERSION "1.0"
@@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
return 0;
}

+static const struct of_device_id btwilink_of_match[] = {
+{
+ .compatible = "btwilink",
+ },
+ {}
+};
+MODULE_DEVICE_TABLE(of, btwilink_of_match);
+
static int bt_ti_probe(struct platform_device *pdev)
{
static struct ti_st *hst;
@@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
.remove = bt_ti_remove,
.driver = {
.name = "btwilink",
+ .owner = THIS_MODULE,
+ .of_match_table = of_match_ptr(btwilink_of_match),
},
};

--
1.9.1

2015-01-09 07:07:01

by Marcel Holtmann

Subject: Re: [PATCH 3/6] btwilink: add minimal device tree support

Hi Gigi,

> Add minimal device tree support to the btwilink driver that is used
> for binding bluetooth with the ti-st shared transport driver.
>
> Signed-off-by: Eyal Reizer <[email protected]>
> Signed-off-by: bvijay <[email protected]>
> Signed-off-by: Gigi Joseph <[email protected]>
> ---
> drivers/bluetooth/btwilink.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
> index 55c135b..95adec3 100644
> --- a/drivers/bluetooth/btwilink.c
> +++ b/drivers/bluetooth/btwilink.c
> @@ -30,6 +30,7 @@
>
> #include <linux/ti_wilink_st.h>
> #include <linux/module.h>
> +#include <linux/of.h>
>
> /* Bluetooth Driver Version */
> #define VERSION "1.0"
> @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
> return 0;
> }
>
> +static const struct of_device_id btwilink_of_match[] = {
> +{
> + .compatible = "btwilink",
> + },
> + {}
> +};

this formatting is bogus. Please construct it similar to what other drivers are doing.

static const struct .. = {
{ .compatible = ".." },

{ } /* Terminating entry */
};

And add an extra empty line before MODULE_DEVICE_TABLE.

> +MODULE_DEVICE_TABLE(of, btwilink_of_match);
> +
> static int bt_ti_probe(struct platform_device *pdev)
> {
> static struct ti_st *hst;
> @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
> .remove = bt_ti_remove,
> .driver = {
> .name = "btwilink",
> + .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(btwilink_of_match),
> },
> };

Regards

Marcel

2015-01-09 04:04:36

by Varka Bhadram

Subject: Re: [PATCH 3/6] btwilink: add minimal device tree support

Hi,

On Fri, Jan 9, 2015 at 9:17 AM, Gigi Joseph <[email protected]> wrote:
> Add minimal device tree support to the btwilink driver that is used
> for binding bluetooth with the ti-st shared transport driver.
>
> Signed-off-by: Eyal Reizer <[email protected]>
> Signed-off-by: bvijay <[email protected]>
> Signed-off-by: Gigi Joseph <[email protected]>
> ---
> drivers/bluetooth/btwilink.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
> index 55c135b..95adec3 100644
> --- a/drivers/bluetooth/btwilink.c
> +++ b/drivers/bluetooth/btwilink.c
> @@ -30,6 +30,7 @@
>
> #include <linux/ti_wilink_st.h>
> #include <linux/module.h>
> +#include <linux/of.h>
>
> /* Bluetooth Driver Version */
> #define VERSION "1.0"
> @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
> return 0;
> }
>
> +static const struct of_device_id btwilink_of_match[] = {
> +{
> + .compatible = "btwilink",
compatible property include the manufacturer name also...
compatible="<manufacturer>,<model>"
> + },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, btwilink_of_match);
> +
> static int bt_ti_probe(struct platform_device *pdev)
> {
> static struct ti_st *hst;
> @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
> .remove = bt_ti_remove,
> .driver = {
> .name = "btwilink",
> + .owner = THIS_MODULE,
No need to update this field. It will be updated by driver core.
> + .of_match_table = of_match_ptr(btwilink_of_match),
> },
> };
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Thanks and Regards,
Varka Bhadram.

2015-03-21 05:21:17

by Marcel Holtmann

Subject: Re: [PATCH v2 3/6] btwilink: add minimal device tree support

Hi Gigi,

> Add minimal device tree support to the btwilink driver that is used
> for binding bluetooth with the ti-st shared transport driver.
>
> Signed-off-by: Eyal Reizer <[email protected]>
> Signed-off-by: bvijay <[email protected]>
> Signed-off-by: Gigi Joseph <[email protected]>
> ---
> Changes in v2:
> * Reformat device_id table to match other drivers
> * Add empty line before MODULE_DEVICE_TABLE
>
> drivers/bluetooth/btwilink.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)

I was wondering if you do not want to document this Documentation/devicetree/bindings/ or some place on what this entries actually means and how you use it.

Regards

Marcel

2015-03-21 05:17:48

by Gigi Joseph

Subject: [PATCH v2 3/6] btwilink: add minimal device tree support

Add minimal device tree support to the btwilink driver that is used
for binding bluetooth with the ti-st shared transport driver.

Signed-off-by: Eyal Reizer <[email protected]>
Signed-off-by: bvijay <[email protected]>
Signed-off-by: Gigi Joseph <[email protected]>
---
Changes in v2:
* Reformat device_id table to match other drivers
* Add empty line before MODULE_DEVICE_TABLE

drivers/bluetooth/btwilink.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
index 55c135b..ae64b2b 100644
--- a/drivers/bluetooth/btwilink.c
+++ b/drivers/bluetooth/btwilink.c
@@ -30,6 +30,7 @@

#include <linux/ti_wilink_st.h>
#include <linux/module.h>
+#include <linux/of.h>

/* Bluetooth Driver Version */
#define VERSION "1.0"
@@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
return 0;
}

+static const struct of_device_id btwilink_of_match[] = {
+ { .compatible = "btwilink" },
+
+ { } /* Terminating entry */
+};
+
+MODULE_DEVICE_TABLE(of, btwilink_of_match);
+
static int bt_ti_probe(struct platform_device *pdev)
{
static struct ti_st *hst;
@@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
.remove = bt_ti_remove,
.driver = {
.name = "btwilink",
+ .owner = THIS_MODULE,
+ .of_match_table = of_match_ptr(btwilink_of_match),
},
};

--
1.9.1