2013-10-24 07:10:37

by Andrei Emeltchenko

Subject: [PATCHv1 0/2] Enable av interface

From: Andrei Emeltchenko <[email protected]>

For some reason get av interface was missing from hal-bluetooth and from
hal test tool.

PS: Not sure that haltest is fully implemented, Jerzy please comment here.

Andrei Emeltchenko (2):
android: haltest: Enable av interface in test tool
android: Enable AV interface

android/client/if-bt.c | 2 +-
android/hal-bluetooth.c | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)

--
1.7.10.4

2013-10-24 07:39:07

by Jerzy Kasenberg

Subject: Re: [PATCHv1 0/2] Enable av interface

On 24 October 2013 09:10, Andrei Emeltchenko
<[email protected]> wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> For some reason get av interface was missing from hal-bluetooth and from
> hal test tool.
>
> PS: Not sure that haltest is fully implemented, Jerzy please comment here.

I must have missed if-bt in commit.
Thanks Andrei.
Apart from one line in if-bt.c all code to call av interface is there
and should be
functional.

>
> Andrei Emeltchenko (2):
> android: haltest: Enable av interface in test tool
> android: Enable AV interface
>
> android/client/if-bt.c | 2 +-
> android/hal-bluetooth.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Jerzy

2013-10-24 07:28:17

by Luiz Augusto von Dentz

Subject: Re: [PATCHv1 0/2] Enable av interface

Hi Andrei,

On Thu, Oct 24, 2013 at 10:10 AM, Andrei Emeltchenko
<[email protected]> wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> For some reason get av interface was missing from hal-bluetooth and from
> hal test tool.
>
> PS: Not sure that haltest is fully implemented, Jerzy please comment here.
>
> Andrei Emeltchenko (2):
> android: haltest: Enable av interface in test tool
> android: Enable AV interface
>
> android/client/if-bt.c | 2 +-
> android/hal-bluetooth.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> --
> 1.7.10.4

Pushed, thanks.


--
Luiz Augusto von Dentz

2013-10-24 07:10:38

by Andrei Emeltchenko

Subject: [PATCHv1 1/2] android: haltest: Enable av interface in test tool

From: Andrei Emeltchenko <[email protected]>

---
android/client/if-bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/client/if-bt.c b/android/client/if-bt.c
index 2d9c0b5..f5c84c1 100644
--- a/android/client/if-bt.c
+++ b/android/client/if-bt.c
@@ -803,7 +803,7 @@ static void get_profile_interface_p(int argc, const char **argv)
if (strcmp(BT_PROFILE_HANDSFREE_ID, id) == 0)
pif = &dummy; /* TODO: change when if_hf is there */
else if (strcmp(BT_PROFILE_ADVANCED_AUDIO_ID, id) == 0)
- pif = &dummy; /* TODO: change when if_av is there */
+ pif = (const void **)&if_av;
else if (strcmp(BT_PROFILE_HEALTH_ID, id) == 0)
pif = &dummy; /* TODO: change when if_hl is there */
else if (strcmp(BT_PROFILE_SOCKETS_ID, id) == 0)
--
1.7.10.4

2013-10-24 07:10:39

by Andrei Emeltchenko

Subject: [PATCHv1 2/2] android: Enable AV interface

From: Andrei Emeltchenko <[email protected]>

Include av_interface to get_interface function.
---
android/hal-bluetooth.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/android/hal-bluetooth.c b/android/hal-bluetooth.c
index d988778..52c7c68 100644
--- a/android/hal-bluetooth.c
+++ b/android/hal-bluetooth.c
@@ -310,6 +310,9 @@ static const void *get_profile_interface(const char *profile_id)
if (!strcmp(profile_id, BT_PROFILE_PAN_ID))
return bt_get_pan_interface();

+ if (!strcmp(profile_id, BT_PROFILE_ADVANCED_AUDIO_ID))
+ return bt_get_av_interface();
+
return NULL;
}

--
1.7.10.4