2014-10-20 14:53:33

by Alfonso Acosta

[permalink] [raw]
Subject: Re: [PATCH v4 2/2] core: Add subscription API for Manufacturer Specific Data

Hi Johan,


>
> This patch also doesn't compile (the error from the first patch might
> have gone away, but then there's this new one):
>
> src/adapter.c:4654:6: error: no previous declaration for ‘adapter_msd_notify’ [-Werror=missing-declarations]
> void adapter_msd_notify(struct btd_adapter *adapter, struct btd_device *dev,
> ^
> cc1: all warnings being treated as errors
> make[1]: *** [src/bluetoothd-adapter.o] Error 1


v5 corrects this problem.

I didn't know that -Wall is only enabled when passing
--enable-maintainer-mode to configure (which I wasn't doing).

--
Alfonso Acosta

Embedded Systems Engineer at Spotify
Birger Jarlsgatan 61, Stockholm, Sweden
http://www.spotify.com