2015-04-22 08:39:57

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ] unit/test-gdbus-client: Fix hanging if D-Bus fails to launch

From: Luiz Augusto von Dentz <[email protected]>

In case D-Bus fails to launch make the test fails so it does not hang
other tests.
---
unit/test-gdbus-client.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/unit/test-gdbus-client.c b/unit/test-gdbus-client.c
index 5a4b974..7e16d16 100644
--- a/unit/test-gdbus-client.c
+++ b/unit/test-gdbus-client.c
@@ -72,6 +72,7 @@ static struct context *create_context(void)
}

g_free(context);
+ tester_test_failed();
return NULL;
}

--
2.1.0



2015-04-22 21:12:41

by Arman Uguray

[permalink] [raw]
Subject: Re: [PATCH BlueZ] unit/test-gdbus-client: Fix hanging if D-Bus fails to launch

Hi Luiz,

> On Wed, Apr 22, 2015 at 1:39 AM, Luiz Augusto von Dentz <[email protected]> wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> In case D-Bus fails to launch make the test fails so it does not hang
> other tests.
> ---
> unit/test-gdbus-client.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/unit/test-gdbus-client.c b/unit/test-gdbus-client.c
> index 5a4b974..7e16d16 100644
> --- a/unit/test-gdbus-client.c
> +++ b/unit/test-gdbus-client.c
> @@ -72,6 +72,7 @@ static struct context *create_context(void)
> }
>
> g_free(context);
> + tester_test_failed();
> return NULL;
> }
>
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Verified and pushed.

Thanks,
Arman