2014-01-31 19:55:23

by Marcel Holtmann

Subject: [PATCH 3/3] Bluetooth: Remove use_debug_keys debugfs entry

Since the use of debug keys can not be identified from the current
settings information, this debugfs entry is no longer.

Signed-off-by: Marcel Holtmann <[email protected]>
---
net/bluetooth/hci_core.c | 20 --------------------
1 file changed, 20 deletions(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index d370b432aea6..7a44c8c1037a 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -285,24 +285,6 @@ static const struct file_operations link_keys_fops = {
.release = single_release,
};

-static ssize_t use_debug_keys_read(struct file *file, char __user *user_buf,
- size_t count, loff_t *ppos)
-{
- struct hci_dev *hdev = file->private_data;
- char buf[3];
-
- buf[0] = test_bit(HCI_DEBUG_KEYS, &hdev->dev_flags) ? 'Y': 'N';
- buf[1] = '\n';
- buf[2] = '\0';
- return simple_read_from_buffer(user_buf, count, ppos, buf, 2);
-}
-
-static const struct file_operations use_debug_keys_fops = {
- .open = simple_open,
- .read = use_debug_keys_read,
- .llseek = default_llseek,
-};
-
static int dev_class_show(struct seq_file *f, void *ptr)
{
struct hci_dev *hdev = f->private;
@@ -1494,8 +1476,6 @@ static int __hci_init(struct hci_dev *hdev)
hdev, &inquiry_cache_fops);
debugfs_create_file("link_keys", 0400, hdev->debugfs,
hdev, &link_keys_fops);
- debugfs_create_file("use_debug_keys", 0444, hdev->debugfs,
- hdev, &use_debug_keys_fops);
debugfs_create_file("dev_class", 0444, hdev->debugfs,
hdev, &dev_class_fops);
debugfs_create_file("voice_setting", 0444, hdev->debugfs,
--
1.8.5.3

2014-01-31 21:39:00

by Marcel Holtmann

Subject: Re: [PATCH 3/3] Bluetooth: Remove use_debug_keys debugfs entry

Hi Anderson,

>> Since the use of debug keys can not be identified from the current
>> settings information, this debugfs entry is no longer.
>
> I believe you meant "debug keys can be identified..." and "is no
> longer necessary.?

indeed I did.

Johan, in case you go ahead with applying this patch, please fix this up.

Regards

Marcel

2014-01-31 21:18:02

by Anderson Lizardo

Subject: Re: [PATCH 3/3] Bluetooth: Remove use_debug_keys debugfs entry

Hi Marcel,

On Fri, Jan 31, 2014 at 3:55 PM, Marcel Holtmann <[email protected]> wrote:
> Since the use of debug keys can not be identified from the current
> settings information, this debugfs entry is no longer.

I believe you meant "debug keys can be identified..." and "is no
longer necessary."

Best Regards,
--
Anderson Lizardo
http://www.indt.org/?lang=en
INdT - Manaus - Brazil

2014-02-02 01:48:50

by Johan Hedberg

Subject: Re: [PATCH 3/3] Bluetooth: Remove use_debug_keys debugfs entry

Hi Marcel,

On Fri, Jan 31, 2014, Marcel Holtmann wrote:
> >> Since the use of debug keys can not be identified from the current
> >> settings information, this debugfs entry is no longer.
> >
> > I believe you meant "debug keys can be identified..." and "is no
> > longer necessary.”
>
> indeed I did.
>
> Johan, in case you go ahead with applying this patch, please fix this up.

Done. All three patches in the set are now in the bluetooth-next tree.

Johan