2024-01-08 18:21:20

by Breno Leitao

Subject: [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to IPv6 over Low power Wireless Personal Area Network.

Signed-off-by: Breno Leitao <[email protected]>
---
net/6lowpan/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
index 7b3341cef926..80d83151ef29 100644
--- a/net/6lowpan/core.c
+++ b/net/6lowpan/core.c
@@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)

module_init(lowpan_module_init);
module_exit(lowpan_module_exit);
-
+MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
MODULE_LICENSE("GPL");
--
2.39.3

2024-01-10 01:05:48

by Alexander Aring

Subject: Re: [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN

Hi,

On Tue, Jan 9, 2024 at 8:04 PM Alexander Aring <[email protected]> wrote:
>
> Hi,
>
> On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <[email protected]> wrote:
> >
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to IPv6 over Low power Wireless Personal Area Network.
> >
> > Signed-off-by: Breno Leitao <[email protected]>
> > ---
> > net/6lowpan/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> > index 7b3341cef926..80d83151ef29 100644
> > --- a/net/6lowpan/core.c
> > +++ b/net/6lowpan/core.c
> > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
> >
> > module_init(lowpan_module_init);
> > module_exit(lowpan_module_exit);
> > -
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
>
> Here is a nitpick as well. The correct acronym [0] is "IPv6 over
> Low-Power Wireless Personal Area Network", otherwise it is okay.
>
> Acked-by: Alexander Aring <[email protected]>
>
> - Alex

[0] https://datatracker.ietf.org/wg/6lowpan/about/

2024-01-10 09:19:23

by Breno Leitao

Subject: Re: [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN

On Tue, Jan 09, 2024 at 08:04:47PM -0500, Alexander Aring wrote:
> Hi,
>
> On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <[email protected]> wrote:
> >
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to IPv6 over Low power Wireless Personal Area Network.
> >
> > Signed-off-by: Breno Leitao <[email protected]>
> > ---
> > net/6lowpan/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> > index 7b3341cef926..80d83151ef29 100644
> > --- a/net/6lowpan/core.c
> > +++ b/net/6lowpan/core.c
> > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
> >
> > module_init(lowpan_module_init);
> > module_exit(lowpan_module_exit);
> > -
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
>
> Here is a nitpick as well. The correct acronym [0] is "IPv6 over
> Low-Power Wireless Personal Area Network", otherwise it is okay.

Thanks. I will update.