2021-11-26 22:12:48

by Łukasz Bartosik

[permalink] [raw]
Subject: [PATCH v1] Bluetooth: btmtksdio: enable msft opcode

From: Łukasz Bartosik <[email protected]>

Enable msft opcode for btmtksdio driver.

Signed-off-by: Łukasz Bartosik <[email protected]>
---
drivers/bluetooth/btmtksdio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index d9cf0c492e29..2a7a615663b9 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
if (enable_autosuspend)
pm_runtime_allow(bdev->dev);

+ hci_set_msft_opcode(hdev, 0xFD30);
bt_dev_info(hdev, "Device setup in %llu usecs", duration);

return 0;
--
2.34.0.rc2.393.gf8c9666880-goog



2021-11-29 08:11:47

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH v1] Bluetooth: btmtksdio: enable msft opcode

Hi Lukasz,

> Enable msft opcode for btmtksdio driver.
>
> Signed-off-by: Łukasz Bartosik <[email protected]>
> ---
> drivers/bluetooth/btmtksdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
> index d9cf0c492e29..2a7a615663b9 100644
> --- a/drivers/bluetooth/btmtksdio.c
> +++ b/drivers/bluetooth/btmtksdio.c
> @@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
> if (enable_autosuspend)
> pm_runtime_allow(bdev->dev);
>
> + hci_set_msft_opcode(hdev, 0xFD30);
> bt_dev_info(hdev, "Device setup in %llu usecs", duration);

can we get someone from Mediatek to sign off on this and that all SDIO based device support the MSFT extension.

Regards

Marcel


2021-11-29 22:03:56

by Sean Wang

[permalink] [raw]
Subject: Re:[PATCH v1] Bluetooth: btmtksdio: enable msft opcode

From: Sean Wang <[email protected]>

>Enable msft opcode for btmtksdio driver.
>
>Signed-off-by: Łukasz Bartosik <[email protected]>
>---
> drivers/bluetooth/btmtksdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index d9cf0c492e29..2a7a615663b9 100644
>--- a/drivers/bluetooth/btmtksdio.c
>+++ b/drivers/bluetooth/btmtksdio.c
>@@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
> if (enable_autosuspend)
> pm_runtime_allow(bdev->dev);
>
>+ hci_set_msft_opcode(hdev, 0xFD30);

Hi Łukasz,

msft feature is supposed only supported on mt7921. Could you help rework the patch to enalbe msft opocde only for mt7921?

Sean

> bt_dev_info(hdev, "Device setup in %llu usecs", duration);
>
> return 0;
>

2021-11-30 13:01:50

by Łukasz Bartosik

[permalink] [raw]
Subject: Re: [PATCH v1] Bluetooth: btmtksdio: enable msft opcode

pon., 29 lis 2021 o 22:01 <[email protected]> napisał(a):
>
> From: Sean Wang <[email protected]>
>
> >Enable msft opcode for btmtksdio driver.
> >
> >Signed-off-by: Łukasz Bartosik <[email protected]>
> >---
> > drivers/bluetooth/btmtksdio.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index d9cf0c492e29..2a7a615663b9 100644
> >--- a/drivers/bluetooth/btmtksdio.c
> >+++ b/drivers/bluetooth/btmtksdio.c
> >@@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
> > if (enable_autosuspend)
> > pm_runtime_allow(bdev->dev);
> >
> >+ hci_set_msft_opcode(hdev, 0xFD30);
>
> Hi Łukasz,
>
> msft feature is supposed only supported on mt7921. Could you help rework the patch to enalbe msft opocde only for mt7921?
>
> Sean
>

Hi Sean,

Thanks for the input. I will update the patch so that msft opcode is
enabled only for mt7921.

Regards,
Lukasz

> > bt_dev_info(hdev, "Device setup in %llu usecs", duration);
> >
> > return 0;
> >