2020-03-04 20:32:21

by Alain Michaud

Subject: [BlueZ PATCH v2] Adding definitions for Wide Band Speech configuration

This change adds the corresponding user space definition for wide band
speech.

---

lib/mgmt.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/mgmt.h b/lib/mgmt.h
index 101cf5f95..d1f0a6053 100644
--- a/lib/mgmt.h
+++ b/lib/mgmt.h
@@ -101,7 +101,8 @@ struct mgmt_rp_read_index_list {
#define MGMT_SETTING_PRIVACY 0x00002000
#define MGMT_SETTING_CONFIGURATION 0x00004000
#define MGMT_SETTING_STATIC_ADDRESS 0x00008000
-#define MGMT_SETTING_PHY_CONFIGURATION 0x00010000
+#define MGMT_SETTING_PHY_CONFIGURATION 0x00010000
+#define MGMT_SETTING_WIDE_BAND_SPEECH 0x00020000

#define MGMT_OP_READ_INFO 0x0004
struct mgmt_rp_read_info {
@@ -599,6 +600,8 @@ struct mgmt_cp_set_blocked_keys {
struct mgmt_blocked_key_info keys[0];
} __packed;

+#define MGMT_OP_SET_WIDE_BAND_SPEECH 0x0047
+
#define MGMT_EV_CMD_COMPLETE 0x0001
struct mgmt_ev_cmd_complete {
uint16_t opcode;
--
2.25.1.481.gfbce0eb801-goog

2020-03-05 11:11:13

by Marcel Holtmann

Subject: Re: [BlueZ PATCH v2] Adding definitions for Wide Band Speech configuration

Hi Alain,

> This change adds the corresponding user space definition for wide band
> speech.
>
> ---
>
> lib/mgmt.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

patch has been applied.

However I did change WIDE_BAND to WIDEBAND as mentioned in the other review.

Regards

Marcel

2020-03-05 14:38:03

by Alain Michaud

Subject: Re: [BlueZ PATCH v2] Adding definitions for Wide Band Speech configuration

Ok, thanks Marcel, I'll send v4 of the other patch with your suggested changes.


On Thu, Mar 5, 2020 at 6:10 AM Marcel Holtmann <[email protected]> wrote:
>
> Hi Alain,
>
> > This change adds the corresponding user space definition for wide band
> > speech.
> >
> > ---
> >
> > lib/mgmt.h | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
>
> patch has been applied.
>
> However I did change WIDE_BAND to WIDEBAND as mentioned in the other review.
>
> Regards
>
> Marcel
>