2020-05-04 15:35:49

by Alain Michaud

Subject: [BlueZ PATCH v1] Fixing opcode definition order

Fixing what looks like a bad merge in the opcode order.

---

lib/mgmt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/mgmt.h b/lib/mgmt.h
index e46e08ba8..c81286460 100644
--- a/lib/mgmt.h
+++ b/lib/mgmt.h
@@ -586,6 +586,8 @@ struct mgmt_cp_set_phy_confguration {

#define MGMT_OP_SET_BLOCKED_KEYS 0x0046

+#define MGMT_OP_SET_WIDEBAND_SPEECH 0x0047
+
#define MGMT_OP_READ_SECURITY_INFO 0x0048
struct mgmt_rp_read_security_info {
uint16_t sec_len;
@@ -606,8 +608,6 @@ struct mgmt_cp_set_blocked_keys {
struct mgmt_blocked_key_info keys[0];
} __packed;

-#define MGMT_OP_SET_WIDEBAND_SPEECH 0x0047
-
#define MGMT_EV_CMD_COMPLETE 0x0001
struct mgmt_ev_cmd_complete {
uint16_t opcode;
--
2.26.2.526.g744177e7f7-goog

2020-05-04 15:38:04

by Alain Michaud

Subject: Re: [BlueZ PATCH v1] Fixing opcode definition order

Please ignore, will send a v2 shortly.

On Mon, May 4, 2020 at 11:31 AM Alain Michaud <[email protected]> wrote:
>
> Fixing what looks like a bad merge in the opcode order.
>
> ---
>
> lib/mgmt.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/mgmt.h b/lib/mgmt.h
> index e46e08ba8..c81286460 100644
> --- a/lib/mgmt.h
> +++ b/lib/mgmt.h
> @@ -586,6 +586,8 @@ struct mgmt_cp_set_phy_confguration {
>
> #define MGMT_OP_SET_BLOCKED_KEYS 0x0046
>
> +#define MGMT_OP_SET_WIDEBAND_SPEECH 0x0047
> +
> #define MGMT_OP_READ_SECURITY_INFO 0x0048
> struct mgmt_rp_read_security_info {
> uint16_t sec_len;
> @@ -606,8 +608,6 @@ struct mgmt_cp_set_blocked_keys {
> struct mgmt_blocked_key_info keys[0];
> } __packed;
>
> -#define MGMT_OP_SET_WIDEBAND_SPEECH 0x0047
> -
> #define MGMT_EV_CMD_COMPLETE 0x0001
> struct mgmt_ev_cmd_complete {
> uint16_t opcode;
> --
> 2.26.2.526.g744177e7f7-goog
>