2011-08-26 22:39:01

by Burt Silverman

Subject: [PATCH] Print an error message if g_dbus_setup_bus fails.

That is standard processing when dbus_error_is_set() returns true, according to
dbus/dbus/dbus-errors.c.
In this case of g_dbus_setup_bus(), it provides extra help for determing the
specific cause of the error.
---
src/main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/main.c b/src/main.c
index 7fecc5a..6dc60a4 100644
--- a/src/main.c
+++ b/src/main.c
@@ -311,6 +311,7 @@ static int connect_dbus(void)
conn = g_dbus_setup_bus(DBUS_BUS_SYSTEM, BLUEZ_NAME, &err);
if (!conn) {
if (dbus_error_is_set(&err)) {
+ g_printerr("an error occurred: %s\n", err.message);
dbus_error_free(&err);
return -EIO;
}
--
1.7.6

2011-08-30 10:13:30

by Johan Hedberg

Subject: Re: [PATCH] Print an error message if g_dbus_setup_bus fails.

Hi Burt,

On Fri, Aug 26, 2011, Burt Silverman wrote:
> That is standard processing when dbus_error_is_set() returns true, according to
> dbus/dbus/dbus-errors.c.
> In this case of g_dbus_setup_bus(), it provides extra help for determing the
> specific cause of the error.
> ---
> src/main.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Applied (after I made the message prefix a bit more descriptive).
Thanks.

Johan

2011-09-08 15:09:26

by Burt Silverman

Subject: Re: [PATCH] Print an error message if g_dbus_setup_bus fails.

Thanks, Johan. I use Fedora Linux, and their "preupgrade" mechanism
often gets me into trouble, in various places, including bluetooth!
--Burt