2013-06-05 02:16:55

by Wei Yongjun

Subject: [PATCH] Bluetooth: btmrvl: fix error return code in btmrvl_sdio_card_to_host()

From: Wei Yongjun <[email protected]>

Fix to return -ENOMEM in the skb alloc error handling case
instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/bluetooth/btmrvl_sdio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 13693b7..75c2626 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -554,6 +554,7 @@ static int btmrvl_sdio_card_to_host(struct btmrvl_private *priv)
skb = bt_skb_alloc(num_blocks * blksz + BTSDIO_DMA_ALIGN, GFP_ATOMIC);
if (skb == NULL) {
BT_ERR("No free skb");
+ ret = -ENOMEM;
goto exit;
}

2013-06-05 15:53:13

by Gustavo Padovan

Subject: Re: [PATCH] Bluetooth: btmrvl: fix error return code in btmrvl_sdio_card_to_host()

Hi Wei,

* Wei Yongjun <[email protected]> [2013-06-05 10:16:55 +0800]:

> From: Wei Yongjun <[email protected]>
>
> Fix to return -ENOMEM in the skb alloc error handling case
> instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 1 +
> 1 file changed, 1 insertion(+)

Patch has been applied to bluetooth.git. Thanks.

Gustavo