2014-06-23 13:49:46

by Loic Poulain

Subject: [PATCHv2] Bluetooth: Remove redundant calls to h5_reset_rx

h5_reset_rx is unconditionally called at the end of
h5_complete_rx_pkt, no need to call it anymore after
that.

Signed-off-by: Loic Poulain <[email protected]>
---
v2: remove unused h5

drivers/bluetooth/hci_h5.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
index 04680ea..1fe9dba 100644
--- a/drivers/bluetooth/hci_h5.c
+++ b/drivers/bluetooth/hci_h5.c
@@ -355,10 +355,7 @@ static void h5_complete_rx_pkt(struct hci_uart *hu)

static int h5_rx_crc(struct hci_uart *hu, unsigned char c)
{
- struct h5 *h5 = hu->priv;
-
h5_complete_rx_pkt(hu);
- h5_reset_rx(h5);

return 0;
}
@@ -373,7 +370,6 @@ static int h5_rx_payload(struct hci_uart *hu, unsigned char c)
h5->rx_pending = 2;
} else {
h5_complete_rx_pkt(hu);
- h5_reset_rx(h5);
}

return 0;
--
1.8.3.2

2014-06-23 14:04:40

by Marcel Holtmann

Subject: Re: [PATCHv2] Bluetooth: Remove redundant calls to h5_reset_rx

Hi Loic,

> h5_reset_rx is unconditionally called at the end of
> h5_complete_rx_pkt, no need to call it anymore after
> that.
>
> Signed-off-by: Loic Poulain <[email protected]>
> ---
> v2: remove unused h5
>
> drivers/bluetooth/hci_h5.c | 4 ----
> 1 file changed, 4 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel