2018-12-05 20:41:39

by Paweł Chmiel

Subject: [PATCH] Bluetooth: btbcm: Add entry for BCM4329B1 UART bluetooth

This patch adds the device ID for the BCM 4329 combo module used
in the Samsung Aries based phones (Galaxy S and it's variants).

```
[ 11.508980] Bluetooth: hci0: BCM: chip id 41
[ 11.518975] Bluetooth: hci0: BCM: features 0x04
[ 11.550132] Bluetooth: hci0: BCM4329B1
[ 11.557046] Bluetooth: hci0: BCM4329B1 (002.002.023) build 0000
[ 13.737071] Bluetooth: hci0: BCM4329B1 (002.002.023) build 0744
```

Output from hciconfig

```
hci0: Type: Primary Bus: UART
BD Address: 43:29:B1:55:00:00 ACL MTU: 1021:6 SCO MTU: 64:1
UP RUNNING
RX bytes:1675 acl:0 sco:0 events:145 errors:0
TX bytes:20426 acl:0 sco:0 commands:146 errors:0
Features: 0xbf 0xfe 0x8f 0xfe 0x9b 0xff 0x79 0x83
Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
Link policy: RSWITCH SNIFF
Link mode: SLAVE ACCEPT
Name: 'aries'
Class: 0x000000
Service Classes: Unspecified
Device Class: Miscellaneous,
HCI Version: 2.1 (0x4) Revision: 0x2e8
LMP Version: 2.1 (0x4) Subversion: 0x4217
Manufacturer: Broadcom Corporation (15)
```

Signed-off-by: Paweł Chmiel <[email protected]>
---
drivers/bluetooth/btbcm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index e3e4d929e74f..ba330096d2c6 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -330,6 +330,7 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
{ 0x2209, "BCM43430A1" }, /* 001.002.009 */
{ 0x6119, "BCM4345C0" }, /* 003.001.025 */
{ 0x230f, "BCM4356A2" }, /* 001.003.015 */
+ { 0x4217, "BCM4329B1" }, /* 002.002.023 */
{ }
};

--
2.17.1

2018-12-18 23:50:26

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: btbcm: Add entry for BCM4329B1 UART bluetooth

Hi Pawel,

> This patch adds the device ID for the BCM 4329 combo module used
> in the Samsung Aries based phones (Galaxy S and it's variants).
>
> ```
> [ 11.508980] Bluetooth: hci0: BCM: chip id 41
> [ 11.518975] Bluetooth: hci0: BCM: features 0x04
> [ 11.550132] Bluetooth: hci0: BCM4329B1
> [ 11.557046] Bluetooth: hci0: BCM4329B1 (002.002.023) build 0000
> [ 13.737071] Bluetooth: hci0: BCM4329B1 (002.002.023) build 0744
> ```
>
> Output from hciconfig
>
> ```
> hci0: Type: Primary Bus: UART
> BD Address: 43:29:B1:55:00:00 ACL MTU: 1021:6 SCO MTU: 64:1
> UP RUNNING
> RX bytes:1675 acl:0 sco:0 events:145 errors:0
> TX bytes:20426 acl:0 sco:0 commands:146 errors:0
> Features: 0xbf 0xfe 0x8f 0xfe 0x9b 0xff 0x79 0x83
> Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
> Link policy: RSWITCH SNIFF
> Link mode: SLAVE ACCEPT
> Name: 'aries'
> Class: 0x000000
> Service Classes: Unspecified
> Device Class: Miscellaneous,
> HCI Version: 2.1 (0x4) Revision: 0x2e8
> LMP Version: 2.1 (0x4) Subversion: 0x4217
> Manufacturer: Broadcom Corporation (15)
> ```
>
> Signed-off-by: Paweł Chmiel <[email protected]>
> ---
> drivers/bluetooth/btbcm.c | 1 +
> 1 file changed, 1 insertion(+)

please update this patch so it applies cleanly against latest bluetooth-next tree.

Regards

Marcel