Hi Guenter,
> alpha:allmodconfig fails to build in -next with
>
> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>
> BOTHER is not defined for all architectures and otherwise only
> used with '#ifdef BOTHER'.
thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
Regards
Marcel
Hi Marcel,
-----Original Message-----
From: Marcel Holtmann [mailto:[email protected]]=20
Sent: Monday, June 15, 2015 10:43 AM
To: Ilya Faenson
Cc: Guenter Roeck; [email protected]; Frederic Danis; BlueZ deve=
lopment; [email protected]
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support ope=
rational speed during setup'
Hi Ilya,
>>> alpha:allmodconfig fails to build in -next with
>>>=20
>>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>>=20
>>> BOTHER is not defined for all architectures and otherwise only
>>> used with '#ifdef BOTHER'.
>>=20
>> thanks for the report. Is this something that should be #ifdef at the us=
ing side or maybe just fixed for the other architectures.
>>=20
>=20
> So far it has been fixed with #ifdef, and this is the first code which
> uses it outside drivers/tty. So my first tendency would be to fix it
> on the user side.
>=20
> However, looking into it, I think only alpha and avr32 are affected.
> Let me submit patches against those and see where it goes.
>=20
> IF: The BOTHER flag should not be involved in setting the baud rate at al=
l. I've published a patch last week that implements the hci_uart_set_baudra=
te properly (in my opinion).
can you extract this and just submit that version. We might just take that =
into hci_ldisc.c right away.
IF: I've published my version now, thanks.
However fixing the #ifdef around BOTHER is useful as well since they look u=
nneeded. At least I can not see a reason why a platform would not define th=
em.
Regards
Marcel
Hi Ilya,
>>> alpha:allmodconfig fails to build in -next with
>>>
>>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>>
>>> BOTHER is not defined for all architectures and otherwise only
>>> used with '#ifdef BOTHER'.
>>
>> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>>
>
> So far it has been fixed with #ifdef, and this is the first code which
> uses it outside drivers/tty. So my first tendency would be to fix it
> on the user side.
>
> However, looking into it, I think only alpha and avr32 are affected.
> Let me submit patches against those and see where it goes.
>
> IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion).
can you extract this and just submit that version. We might just take that into hci_ldisc.c right away.
However fixing the #ifdef around BOTHER is useful as well since they look unneeded. At least I can not see a reason why a platform would not define them.
Regards
Marcel
Hi Guenter,
-----Original Message-----
From: [email protected] [mailto:linux-bluetooth-owner@v=
ger.kernel.org] On Behalf Of Guenter Roeck
Sent: Monday, June 15, 2015 10:25 AM
To: Marcel Holtmann
Cc: [email protected]; Frederic Danis; BlueZ development; linux-=
[email protected]
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support ope=
rational speed during setup'
On 06/15/2015 06:58 AM, Marcel Holtmann wrote:
> Hi Guenter,
>
>> alpha:allmodconfig fails to build in -next with
>>
>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>
>> BOTHER is not defined for all architectures and otherwise only
>> used with '#ifdef BOTHER'.
>
> thanks for the report. Is this something that should be #ifdef at the usi=
ng side or maybe just fixed for the other architectures.
>
So far it has been fixed with #ifdef, and this is the first code which
uses it outside drivers/tty. So my first tendency would be to fix it
on the user side.
However, looking into it, I think only alpha and avr32 are affected.
Let me submit patches against those and see where it goes.
IF: The BOTHER flag should not be involved in setting the baud rate at all.=
I've published a patch last week that implements the hci_uart_set_baudrate=
properly (in my opinion).
Guenter
On 06/15/2015 06:58 AM, Marcel Holtmann wrote:
> Hi Guenter,
>
>> alpha:allmodconfig fails to build in -next with
>>
>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>
>> BOTHER is not defined for all architectures and otherwise only
>> used with '#ifdef BOTHER'.
>
> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>
So far it has been fixed with #ifdef, and this is the first code which
uses it outside drivers/tty. So my first tendency would be to fix it
on the user side.
However, looking into it, I think only alpha and avr32 are affected.
Let me submit patches against those and see where it goes.
Guenter