2021-03-23 21:59:22

by Yu Liu

Subject: [RFC PATCH v1] doc/mgmt-api - Return connection direction in Device Connected Event

When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
space we will set the flags to tell if the established connection is
outbound or not. This is useful for the user space to log better metrics
and error messages.

Reviewed-by: Miao-chen Chou <[email protected]>
Reviewed-by: Alain Michaud <[email protected]>
---

Changes in v1:
- Initial change

doc/mgmt-api.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index cab1fffc5..534272045 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -4085,7 +4085,7 @@ Device Connected Event
start using its identity.

The following bits are defined for the Flags parameter:
- 0 Reserved (not in use)
+ 0 Outbound Connection
1 Legacy Pairing
2 Reserved (not in use)

--
2.31.0.291.g576ba9dcdaf-goog

2021-03-23 22:44:06

by bluez.test.bot

Subject: RE: [RFC,v1] doc/mgmt-api - Return connection direction in Device Connected Event

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=454217

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth

2021-03-25 01:36:05

by Marcel Holtmann

Subject: Re: [RFC PATCH v1] doc/mgmt-api - Return connection direction in Device Connected Event

Hi Yu,

> When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
> space we will set the flags to tell if the established connection is
> outbound or not. This is useful for the user space to log better metrics
> and error messages.
>
> Reviewed-by: Miao-chen Chou <[email protected]>
> Reviewed-by: Alain Michaud <[email protected]>
> ---
>
> Changes in v1:
> - Initial change
>
> doc/mgmt-api.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index cab1fffc5..534272045 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -4085,7 +4085,7 @@ Device Connected Event
> start using its identity.
>
> The following bits are defined for the Flags parameter:
> - 0 Reserved (not in use)
> + 0 Outbound Connection
> 1 Legacy Pairing
> 2 Reserved (not in use)

the reserved ones are there to keep in sync with Device Found. So please use the next free one (and reserve it for Device Found).

Also I am not fully in favor of “Outbound Connection”. I rather use the term “Central” in case we are the Central / Master of a connection. Now that however gets into trouble with BR/EDR since there you can switch roles. So maybe “Initiated Connection” is an option.

Regards

Marcel