Add support for BlazarI (cnvi) bluetooth core.
Signed-off-by: Kiran K <[email protected]>
---
drivers/bluetooth/btintel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index dc48352166a5..4f4bd5538b6e 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev,
case 0x19: /* Slr-F */
case 0x1b: /* Mgr */
case 0x1c: /* Gale Peak (GaP) */
+ case 0x1e: /* BlazarI (Bzr) */
break;
default:
bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
@@ -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
case 0x19:
case 0x1b:
case 0x1c:
+ case 0x1e:
hci_set_msft_opcode(hdev, 0xFC1E);
break;
default:
@@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)
case 0x19:
case 0x1b:
case 0x1c:
+ case 0x1e:
/* Display version information of TLV type */
btintel_version_info_tlv(hdev, &ver_tlv);
--
2.34.1
Add VID/PID for Intel Filmore Peak2 (BE201)
Device from /sys/kernel/debug/usb/devices:
T: Bus=09 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=8087 ProdID=0037 Rev= 0.00
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=1ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
Signed-off-by: Kiran K <[email protected]>
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 482d6d76f900..90d1f1697357 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -477,6 +477,7 @@ static const struct usb_device_id quirks_table[] = {
{ USB_DEVICE(0x8087, 0x0033), .driver_info = BTUSB_INTEL_COMBINED },
{ USB_DEVICE(0x8087, 0x0035), .driver_info = BTUSB_INTEL_COMBINED },
{ USB_DEVICE(0x8087, 0x0036), .driver_info = BTUSB_INTEL_COMBINED },
+ { USB_DEVICE(0x8087, 0x0037), .driver_info = BTUSB_INTEL_COMBINED },
{ USB_DEVICE(0x8087, 0x0038), .driver_info = BTUSB_INTEL_COMBINED },
{ USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
{ USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL_COMBINED |
--
2.34.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=849788
---Test result---
Test Summary:
CheckPatch PASS 1.21 seconds
GitLint PASS 0.59 seconds
SubjectPrefix PASS 0.22 seconds
BuildKernel PASS 29.72 seconds
CheckAllWarning PASS 32.10 seconds
CheckSparse PASS 38.11 seconds
CheckSmatch FAIL 35.68 seconds
BuildKernel32 PASS 28.43 seconds
TestRunnerSetup PASS 513.61 seconds
TestRunner_l2cap-tester PASS 20.23 seconds
TestRunner_iso-tester FAIL 34.77 seconds
TestRunner_bnep-tester PASS 5.29 seconds
TestRunner_mgmt-tester PASS 112.66 seconds
TestRunner_rfcomm-tester PASS 7.28 seconds
TestRunner_sco-tester PASS 14.90 seconds
TestRunner_ioctl-tester PASS 7.54 seconds
TestRunner_mesh-tester PASS 5.73 seconds
TestRunner_smp-tester PASS 8.17 seconds
TestRunner_userchan-tester PASS 4.81 seconds
IncrementalBuild PASS 33.92 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 121 (99.2%), Failed: 1, Not Run: 0
Failed Test Cases
ISO Connect Suspend - Success Failed 4.165 seconds
---
Regards,
Linux Bluetooth
Dear Kiran,
Thank you for your patch.
Am 02.05.24 um 07:23 schrieb Kiran K:
> Add support for BlazarI (cnvi) bluetooth core.
It’d be great if you documented the datasheet name and revision.
Also, it’d help people reading the diff, if you added what the support
entails. In this case a note, that it’s a “standard device” and only the
new id needs to be added, would be nice.
> Signed-off-by: Kiran K <[email protected]>
> ---
> drivers/bluetooth/btintel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index dc48352166a5..4f4bd5538b6e 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev,
> case 0x19: /* Slr-F */
> case 0x1b: /* Mgr */
> case 0x1c: /* Gale Peak (GaP) */
> + case 0x1e: /* BlazarI (Bzr) */
> break;
> default:
> bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
> @@ -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
> case 0x19:
> case 0x1b:
> case 0x1c:
> + case 0x1e:
> hci_set_msft_opcode(hdev, 0xFC1E);
> break;
> default:
> @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)
> case 0x19:
> case 0x1b:
> case 0x1c:
> + case 0x1e:
> /* Display version information of TLV type */
> btintel_version_info_tlv(hdev, &ver_tlv);
Kind regards,
Paul
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Thu, 2 May 2024 10:53:55 +0530 you wrote:
> Add support for BlazarI (cnvi) bluetooth core.
>
> Signed-off-by: Kiran K <[email protected]>
> ---
> drivers/bluetooth/btintel.c | 3 +++
> 1 file changed, 3 insertions(+)
Here is the summary with links:
- [v1,1/2] Bluetooth: btintel: Add support for BlazarI
https://git.kernel.org/bluetooth/bluetooth-next/c/d250f0cced62
- [v1,2/2] Bluetooth: btintel: Add support for Filmore Peak2 (BE201)
https://git.kernel.org/bluetooth/bluetooth-next/c/93ff8ae40fcc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Hi Paul,
Appreciate your comments.
> -----Original Message-----
> From: Paul Menzel <[email protected]>
> Sent: Thursday, May 2, 2024 11:24 AM
> To: K, Kiran <[email protected]>
> Cc: [email protected]; Srivatsa, Ravishankar
> <[email protected]>; Tumkur Narayan, Chethan
> <[email protected]>; Devegowda, Chandrashekar
> <[email protected]>
> Subject: Re: [PATCH v1 1/2] Bluetooth: btintel: Add support for BlazarI
>
> Dear Kiran,
>
>
> Thank you for your patch.
>
> Am 02.05.24 um 07:23 schrieb Kiran K:
> > Add support for BlazarI (cnvi) bluetooth core.
>
> It’d be great if you documented the datasheet name and revision.
I am afraid to provide these details as these data is internal.
>
> Also, it’d help people reading the diff, if you added what the support entails.
> In this case a note, that it’s a “standard device” and only the new id needs to
> be added, would be nice.
Ack.
>
> > Signed-off-by: Kiran K <[email protected]>
> > ---
> > drivers/bluetooth/btintel.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index dc48352166a5..4f4bd5538b6e 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev
> *hdev,
> > case 0x19: /* Slr-F */
> > case 0x1b: /* Mgr */
> > case 0x1c: /* Gale Peak (GaP) */
> > + case 0x1e: /* BlazarI (Bzr) */
> > break;
> > default:
> > bt_dev_err(hdev, "Unsupported Intel hardware variant
> (0x%x)", @@
> > -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev
> *hdev, u8 hw_variant)
> > case 0x19:
> > case 0x1b:
> > case 0x1c:
> > + case 0x1e:
> > hci_set_msft_opcode(hdev, 0xFC1E);
> > break;
> > default:
> > @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev
> *hdev)
> > case 0x19:
> > case 0x1b:
> > case 0x1c:
> > + case 0x1e:
> > /* Display version information of TLV type */
> > btintel_version_info_tlv(hdev, &ver_tlv);
>
>
> Kind regards,
>
> Paul
Thanks,
Kiran