2024-05-03 12:03:53

by Naga Bhavani Akella

Subject: [PATCH v1] bluetoothctl: fix for gatt unregister-includes option not working

unregister includes option takes two parameters service uuid and
included service uuid, since the space between them is missing,
the menu option is not working.
When two uuids separated with space is given, it is throwing error.

Signed-off-by: Naga Bhavani Akella mailto:[email protected]
---
client/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/main.c b/client/main.c
index 51d08a67a..c8b0f7f1c 100644
--- a/client/main.c
+++ b/client/main.c
@@ -3060,7 +3060,7 @@ static const struct bt_shell_menu gatt_menu = {
"Unregister application service" },
{ "register-includes", "<UUID> [handle]", cmd_register_includes,
"Register as Included service in." },
- { "unregister-includes", "<Service-UUID><Inc-UUID>",
+ { "unregister-includes", "<Service-UUID> <Inc-UUID>",
cmd_unregister_includes,
"Unregister Included service." },
{ "register-characteristic",
--
2.17.1

2024-05-03 12:23:46

by bluez.test.bot

Subject: RE: [v1] bluetoothctl: fix for gatt unregister-includes option not working

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: client/main.c:3060
error: client/main.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth