Dear Shengyu,
Thank you for the patch. Two nits below.
Am 18.09.22 um 08:38 schrieb Shengyu Qu:
> Add IDs to usb_device_id table for WCN6855.
> IDs are extracted from Windows driver of Lenovo
> Thinkpad T14 Gen 2.
Please reflow for 75 characters per line, and maybe don’t add a line
break, or add a blnak between paragraphs.
Please add the Microsoft Windows driver version, and maybe the location
(Internet Archive URL) for reference.
[…]
Kind regards,
Paul
Thanks for your advice. Driver version is 1.0.0.1205 (Windows 10 driver).
Should I resend a patch with modified commit message?
________________________________________
From: Paul Menzel <[email protected]>
Sent: Sunday, September 18, 2022 14:52
To: Shengyu Qu
Cc: [email protected]
Subject: Re: [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855
Dear Shengyu,
Thank you for the patch. Two nits below.
Am 18.09.22 um 08:38 schrieb Shengyu Qu:
> Add IDs to usb_device_id table for WCN6855.
> IDs are extracted from Windows driver of Lenovo
> Thinkpad T14 Gen 2.
Please reflow for 75 characters per line, and maybe don?t add a line
break, or add a blnak between paragraphs.
Please add the Microsoft Windows driver version, and maybe the location
(Internet Archive URL) for reference.
[?]
Kind regards,
Paul
Dear Shengyu,
Am 18.09.22 um 09:13 schrieb Shengyu Qu:
> Thanks for your advice. Driver version is 1.0.0.1205 (Windows 10 driver).
> Should I resend a patch with modified commit message?
Yes, a v2 would be wonderful.
git commit --amend
git format-patch -v 2 …
Kind regards,
Paul