On Wed, Oct 06, 2021 at 06:00:03PM +0530, Balakrishna Godavarthi wrote:
> Subject: arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board
Not super helpful, what does 'update' mean?
It might be easier to have a single patch for both IDP boards, since
the Bluetooth node is added in the common sc7280-idp.dtsi board,
rather than explaining what this patch does :)
> This patch updates bluetooth node in SC7280 IDP2 board.
>
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> index 1fc2add..5c8d54b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> @@ -15,9 +15,15 @@
>
> aliases {
> serial0 = &uart5;
> + bluetooth0 = &bluetooth;
> + hsuart0 = &uart7;
> };
Sort aliases alphabetically
>
> chosen {
> stdout-path = "serial0:115200n8";
> };
> };
> +
> +&bluetooth: wcn6750-bt {
&bluetooth {
> + vddio-supply = <&vreg_l18b_1p8>;
nit: if it's not really common across IDP boards or a default, you could
leave it unconfigured in sc7280-idp.dtsi, and set in both board files.
Just an idea, with only two boards it doesn't really matter too much.
Hi Matthias,
On 2021-10-06 23:09, Matthias Kaehlcke wrote:
> On Wed, Oct 06, 2021 at 06:00:03PM +0530, Balakrishna Godavarthi wrote:
>> Subject: arm64: dts: qcom: sc7280: update bluetooth node in SC7280
>> IDP2 board
>
> Not super helpful, what does 'update' mean?
>
> It might be easier to have a single patch for both IDP boards, since
> the Bluetooth node is added in the common sc7280-idp.dtsi board,
> rather than explaining what this patch does :)
[Bala]: Sure will have one patch.
>
>> This patch updates bluetooth node in SC7280 IDP2 board.
>>
>> Signed-off-by: Balakrishna Godavarthi <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
>> b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
>> index 1fc2add..5c8d54b 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
>> @@ -15,9 +15,15 @@
>>
>> aliases {
>> serial0 = &uart5;
>> + bluetooth0 = &bluetooth;
>> + hsuart0 = &uart7;
>> };
>
> Sort aliases alphabetically
>
>>
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> };
>> +
>> +&bluetooth: wcn6750-bt {
>
> &bluetooth {
>
>> + vddio-supply = <&vreg_l18b_1p8>;
>
> nit: if it's not really common across IDP boards or a default, you
> could
> leave it unconfigured in sc7280-idp.dtsi, and set in both board files.
> Just an idea, with only two boards it doesn't really matter too much.
[Bala]: Sure will update in similar way.