2024-01-08 19:03:26

by Arend Van Spriel

[permalink] [raw]
Subject: Re: License of old broadcom BT firmwares and WiFi calibration files

+ linux-bluetooth
+ Marcel

On 1/8/2024 7:21 PM, Svyatoslav Ryhel wrote:
> пн, 8 січ. 2024 р. о 19:59 Arend Van Spriel <[email protected]> пише:
>>
>> On January 8, 2024 5:48:37 PM Svyatoslav Ryhel <[email protected]> wrote:
>>
>>> пн, 8 січ. 2024 р. о 17:43 Arend Van Spriel <[email protected]>
>>> пише:
>>>>
>>>> On January 4, 2024 10:08:04 AM Svyatoslav Ryhel <[email protected]> wrote:
>>>>
>>>>> ср, 3 січ. 2024 р. о 20:20 Arend Van Spriel <[email protected]>
>>>>> пише:
>>>>>>
>>>>>> On January 3, 2024 6:28:33 PM Svyatoslav Ryhel <[email protected]> wrote:
>>>>>>
>>>>>>> 3 січня 2024 р. 11:22:42 GMT+02:00, Arend Van Spriel
>>>>>>> <[email protected]> написав(-ла):
>>>>>>>> On January 3, 2024 10:14:42 AM Arend Van Spriel
>>>>>>>> <[email protected]> wrote:
>>>>>>>>
>>>>>>>>> + linux-wireless
>>>>>>>>> + Hans de Goede
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On December 16, 2023 9:14:48 PM Svyatoslav Ryhel <[email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> сб, 16 груд. 2023 р. о 21:57 Arend van Spriel
>>>>>>>>>> <[email protected]> пише:
>>>>>>>>>>>
>>>>>>>>>>> On 12/16/2023 6:45 PM, Svyatoslav Ryhel wrote:
>>>>>>>>>>>> Greetings!
>>>>>>>>>>>>
>>>>>>>>>>>> I am trying to submit bluetooth firmwares (BCM4329B1.*,*.hcd and
>>>>>>>>>>>> BCM4330B1.*,*.hcd) and wifi calibration files
>>>>>>>>>>>> (brcmfmac4329-sdio.*,*.txt and brcmfmac4329-sdio.*,*.txt) from a few
>>>>>>>>>>>> Tegra 2 and Tegra 3 based devices into linux-fimware.
>>>>>>>>>>>>
>>>>>>>>>>>> I have faced ambiguous license issue since those files were part of
>>>>>>>>>>>> Android Images of different vendors. Those vendors did not provide a
>>>>>>>>>>>> license nor for android images, not for these files.
>>>>>>>>
>>>>>>>> Does this mean you extracted them from the android image? That probably
>>>>>>>> never get accepted without any license information.
>>>>>>>
>>>>>>> Can Broadcom re-grant license to these files?
>>>>>>>
>>>>>>> This license is for bcm4329 in crespo
>>>>>>> <https://android.googlesource.com/device/samsung/crespo/+/refs/heads/main/self-extractors/broadcom/LICENSE>
>>>>>>
>>>>>> Actually checked this link:
>>>>>>
>>>>>> https://android.googlesource.com/device/samsung/crespo/+/refs/heads/main/proprietary-blobs.txt
>>>>>>
>>>>>> It lists the bcm4329.hcd file as falling under Apache-2.0 license. Same for
>>>>>> asus/grouper.
>>>>>>
>>>>>> Regards,
>>>>>> Arend
>>>>>
>>>>> So this actually resolves ambiguity. Thanks
>>>>
>>>> Yes, but ... you should add them to linux-firmware under the same license.
>>>> That means you need to mark them as such in the WHENCE file. Feel free to
>>>> cc: me for the patch so I can have a look at it.
>>>>
>>>> Regards,
>>>> Arend
>>>
>>> Thank you for your assistance, it is really appreciated and valued but
>>> it was rejected
>>>
>>> https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/114
>>>
>>> I have referred to our conversation.
>>
>> I see and it seems they were correct. My bad. Clearly should not try a
>> career as lawyer.
>>
>> I can try to publish them to linux-firmware, but I have to ask internally.
>>
>> Regards,
>> Arend
>>
>
> Thank you, looking forward to your answer. But keep in mind that
> generic firmware for bluetooth might not be an option. I have tried to
> shuffle them and bluetooth failed.

Okay. I guess there is a naming scheme that btbcm.ko uses. Will look in
the source file how it loads firmware/patch. Actually your merge request
would also tell me. That involves a whole lot more firmware files than
what we discussed earlier.

Regards,
Arend