On Wed, Apr 24, 2019 at 4:37 AM David Miller <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
> Date: Tue, 23 Apr 2019 17:11:32 +0200
>
> > When isdn4linux came up in the context of another patch series, I
> > remembered that we had discussed removing it a while ago.
>
> This seems long overdue to me.
>
> Could you please respin against net-next and I'll just apply this?
Ok. I'll send a pull request then, which should make it easier to deal with
the file removals, as I'm never sure whether 'git format-patch -D' patches
make it across the list correctly, at least I had problems applying them
in the past.
I added a few fixups as in the diff below in the meantime, to deal
with build regressions from the last patch. In particular, the BT_CMTP
(CIP) code also needs to be moved into staging along with the CAPI
core. From what I can find, this was originally used for dial-up
internet connections with 'Bluefritz' ISDN hardware, but it stopped
working many years ago and is no longer useful with after the
public network shutdown either.
Arnd
diff --git a/drivers/staging/isdn/Kconfig b/drivers/staging/isdn/Kconfig
index 77e1b80af716..29d13fcd9e2b 100644
--- a/drivers/staging/isdn/Kconfig
+++ b/drivers/staging/isdn/Kconfig
@@ -1,5 +1,6 @@
menuconfig ISDN_CAPI
tristate "CAPI 2.0 subsystem"
+ depends on NET && NETDEVICES
help
This provides CAPI (the Common ISDN Application Programming
Interface) Version 2.0, a standard making it easy for programs to
@@ -23,6 +24,7 @@ source "drivers/staging/isdn/gigaset/Kconfig"
source "drivers/staging/isdn/hysdn/Kconfig"
+source "drivers/staging/isdn/cmtp/Kconfig"
endif # ISDN_CAPI
diff --git a/drivers/staging/isdn/Makefile b/drivers/staging/isdn/Makefile
index c5e8b8004f65..a74e9163f3c8 100644
--- a/drivers/staging/isdn/Makefile
+++ b/drivers/staging/isdn/Makefile
@@ -7,3 +7,4 @@ obj-$(CONFIG_ISDN_CAPI) += capi/
obj-$(CONFIG_CAPI_AVM) += avm/
obj-$(CONFIG_HYSDN) += hysdn/
obj-$(CONFIG_ISDN_DRV_GIGASET) += gigaset/
+obj-$(CONFIG_BT_CMTP) += cmtp/
diff --git a/net/bluetooth/cmtp/Kconfig b/drivers/staging/isdn/cmtp/Kconfig
similarity index 88%
rename from net/bluetooth/cmtp/Kconfig
rename to drivers/staging/isdn/cmtp/Kconfig
index 939da0fbdd88..1772ca952720 100644
--- a/net/bluetooth/cmtp/Kconfig
+++ b/drivers/staging/isdn/cmtp/Kconfig
@@ -1,6 +1,6 @@
config BT_CMTP
tristate "CMTP protocol support"
- depends on BT_BREDR && ISDN_CAPI
+ depends on BT && BT_BREDR && ISDN_CAPI
help
CMTP (CAPI Message Transport Protocol) is a transport layer
for CAPI messages. CMTP is required for the Bluetooth Common
diff --git a/net/bluetooth/cmtp/Makefile b/drivers/staging/isdn/cmtp/Makefile
similarity index 59%
rename from net/bluetooth/cmtp/Makefile
rename to drivers/staging/isdn/cmtp/Makefile
index 890a9a5a6861..23258b46753c 100644
--- a/net/bluetooth/cmtp/Makefile
+++ b/drivers/staging/isdn/cmtp/Makefile
@@ -5,3 +5,5 @@
obj-$(CONFIG_BT_CMTP) += cmtp.o
cmtp-objs := core.o sock.o capi.o
+
+ccflags-y += -I$(srctree)/$(src)/../include -I$(srctree)/$(src)/../include/uapi
diff --git a/net/bluetooth/cmtp/capi.c b/drivers/staging/isdn/cmtp/capi.c
similarity index 100%
rename from net/bluetooth/cmtp/capi.c
rename to drivers/staging/isdn/cmtp/capi.c
diff --git a/net/bluetooth/cmtp/cmtp.h b/drivers/staging/isdn/cmtp/cmtp.h
similarity index 100%
rename from net/bluetooth/cmtp/cmtp.h
rename to drivers/staging/isdn/cmtp/cmtp.h
diff --git a/net/bluetooth/cmtp/core.c b/drivers/staging/isdn/cmtp/core.c
similarity index 100%
rename from net/bluetooth/cmtp/core.c
rename to drivers/staging/isdn/cmtp/core.c
diff --git a/net/bluetooth/cmtp/sock.c b/drivers/staging/isdn/cmtp/sock.c
similarity index 100%
rename from net/bluetooth/cmtp/sock.c
rename to drivers/staging/isdn/cmtp/sock.c
diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig
index db82a40875e8..f3bfd9ec5e32 100644
--- a/net/bluetooth/Kconfig
+++ b/net/bluetooth/Kconfig
@@ -55,8 +55,6 @@ source "net/bluetooth/rfcomm/Kconfig"
source "net/bluetooth/bnep/Kconfig"
-source "net/bluetooth/cmtp/Kconfig"
-
source "net/bluetooth/hidp/Kconfig"
config BT_HS
diff --git a/net/bluetooth/Makefile b/net/bluetooth/Makefile
index fda41c0b4781..7fdd758f0395 100644
--- a/net/bluetooth/Makefile
+++ b/net/bluetooth/Makefile
@@ -6,7 +6,6 @@
obj-$(CONFIG_BT) += bluetooth.o
obj-$(CONFIG_BT_RFCOMM) += rfcomm/
obj-$(CONFIG_BT_BNEP) += bnep/
-obj-$(CONFIG_BT_CMTP) += cmtp/
obj-$(CONFIG_BT_HIDP) += hidp/
obj-$(CONFIG_BT_6LOWPAN) += bluetooth_6lowpan.o
Hi Arnd,
>>> When isdn4linux came up in the context of another patch series, I
>>> remembered that we had discussed removing it a while ago.
>>
>> This seems long overdue to me.
>>
>> Could you please respin against net-next and I'll just apply this?
>
> Ok. I'll send a pull request then, which should make it easier to deal with
> the file removals, as I'm never sure whether 'git format-patch -D' patches
> make it across the list correctly, at least I had problems applying them
> in the past.
>
> I added a few fixups as in the diff below in the meantime, to deal
> with build regressions from the last patch. In particular, the BT_CMTP
> (CIP) code also needs to be moved into staging along with the CAPI
> core. From what I can find, this was originally used for dial-up
> internet connections with 'Bluefritz' ISDN hardware, but it stopped
> working many years ago and is no longer useful with after the
> public network shutdown either.
>
> Arnd
>
>
> diff --git a/drivers/staging/isdn/Kconfig b/drivers/staging/isdn/Kconfig
> index 77e1b80af716..29d13fcd9e2b 100644
> --- a/drivers/staging/isdn/Kconfig
> +++ b/drivers/staging/isdn/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ISDN_CAPI
> tristate "CAPI 2.0 subsystem"
> + depends on NET && NETDEVICES
> help
> This provides CAPI (the Common ISDN Application Programming
> Interface) Version 2.0, a standard making it easy for programs to
> @@ -23,6 +24,7 @@ source "drivers/staging/isdn/gigaset/Kconfig"
>
> source "drivers/staging/isdn/hysdn/Kconfig"
>
> +source "drivers/staging/isdn/cmtp/Kconfig"
>
> endif # ISDN_CAPI
NAK.
I do not care about isdn4linux, but this is a purely CAPI based driver. So removing (or moving to staging) CAPI support seems rather premature.
Maybe someone would have started talking to us before trying to move this into staging. It is a maintained driver. That it is rather simple and hasn’t seen patches in a long time, doesn’t mean it is not maintained and staging material. I see no reason to tell any user to enable staging tree to get CMTP support.
Regards
Marcel
On Wed, Apr 24, 2019 at 12:24 PM Marcel Holtmann <[email protected]> wrote:
> >>> When isdn4linux came up in the context of another patch series, I
> >>> remembered that we had discussed removing it a while ago.
>
> NAK.
>
> I do not care about isdn4linux, but this is a purely CAPI based driver. So removing (or moving to staging)
> CAPI support seems rather premature.
>
> Maybe someone would have started talking to us before trying to move this into staging. It is a
> maintained driver. That it is rather simple and hasn’t seen patches in a long time, doesn’t mean
> it is not maintained and staging material. I see no reason to tell any user to enable staging tree
> to get CMTP support.
I can definitely leave out the last patch from the series if we know
that there are
still users on CMTP. I searched around for a bit but could not find
any indication
what this is still used for, if anything.
What I found were a couple of references of the driver no longer working
about 10 years ago:
https://wiki.ubuntuusers.de/Archiv/Bluetooth/BlueFritz%21/
https://www.opensuse-forum.de/thread/2776-erledigt-suse-11-2-und-bluefritz/
Is anyone using cmtp for voice or fax services? The use cases from before 2009
that I could find were usually dial-up networking, but that seems pointless now
if the only way to get an ISDN connection is to have it routed over
the internet.
What am I missing?
Arnd
Hi Arnd,
>>>>> When isdn4linux came up in the context of another patch series, I
>>>>> remembered that we had discussed removing it a while ago.
>>
>> NAK.
>>
>> I do not care about isdn4linux, but this is a purely CAPI based driver. So removing (or moving to staging)
>> CAPI support seems rather premature.
>>
>> Maybe someone would have started talking to us before trying to move this into staging. It is a
>> maintained driver. That it is rather simple and hasn’t seen patches in a long time, doesn’t mean
>> it is not maintained and staging material. I see no reason to tell any user to enable staging tree
>> to get CMTP support.
>
> I can definitely leave out the last patch from the series if we know
> that there are
> still users on CMTP. I searched around for a bit but could not find
> any indication
> what this is still used for, if anything.
I would prefer if we leave CAPI support and with that CMTP mainstream and not move that to staging. For isdn4linux, I have no objections to move that to staging since mISDN was suppose to replace it anyway.
> What I found were a couple of references of the driver no longer working
> about 10 years ago:
>
> https://wiki.ubuntuusers.de/Archiv/Bluetooth/BlueFritz%21/
> https://www.opensuse-forum.de/thread/2776-erledigt-suse-11-2-und-bluefritz/
>
> Is anyone using cmtp for voice or fax services? The use cases from before 2009
> that I could find were usually dial-up networking, but that seems pointless now
> if the only way to get an ISDN connection is to have it routed over
> the internet.
I still have the hardware and last time I checked it worked just fine. However you need to set up a proper pairing with the hardware. However that has nothing to do with CMTP since that is just a CAPI message transport protocol.
You can use it for voice and fax service as long as you have the right codecs in place. At the end of the day CAPI is an API for ISDN. And CMTP just being a transport, all ISDN services are possible given the right software / application.
Regards
Marcel
On Wed, Apr 24, 2019 at 4:30 PM Marcel Holtmann <[email protected]> wrote:
>
> Hi Arnd,
>
> >>>>> When isdn4linux came up in the context of another patch series, I
> >>>>> remembered that we had discussed removing it a while ago.
> >>
> >> NAK.
> >>
> >> I do not care about isdn4linux, but this is a purely CAPI based driver. So removing (or moving to staging)
> >> CAPI support seems rather premature.
> >>
> >> Maybe someone would have started talking to us before trying to move this into staging. It is a
> >> maintained driver. That it is rather simple and hasn’t seen patches in a long time, doesn’t mean
> >> it is not maintained and staging material. I see no reason to tell any user to enable staging tree
> >> to get CMTP support.
> >
> > I can definitely leave out the last patch from the series if we know
> > that there are
> > still users on CMTP. I searched around for a bit but could not find
> > any indication
> > what this is still used for, if anything.
>
> I would prefer if we leave CAPI support and with that CMTP mainstream and not move
> that to staging. For isdn4linux, I have no objections to move that to staging since
> mISDN was suppose to replace it anyway.
Sure, I can rework the patch to leave the CAPI subsystem and only move the
other three drivers (avm, hysdn, gigaset) into staging to see if
anyone uses them.
> > What I found were a couple of references of the driver no longer working
> > about 10 years ago:
> >
> > https://wiki.ubuntuusers.de/Archiv/Bluetooth/BlueFritz%21/
> > https://www.opensuse-forum.de/thread/2776-erledigt-suse-11-2-und-bluefritz/
> >
> > Is anyone using cmtp for voice or fax services? The use cases from before 2009
> > that I could find were usually dial-up networking, but that seems pointless now
> > if the only way to get an ISDN connection is to have it routed over
> > the internet.
>
> I still have the hardware and last time I checked it worked just fine. However
> you need to set up a proper pairing with the hardware. However that has nothing
> to do with CMTP since that is just a CAPI message transport protocol.
>
> You can use it for voice and fax service as long as you have the right codecs in
> place. At the end of the day CAPI is an API for ISDN. And CMTP just being a
> transport, all ISDN services are possible given the right software / application.
That does not answer my question. It's clear that you can do all those things
with CAPI and CMTP, but what I was trying to find out is whether anyone still
does.
The gigaset driver is similar here, you can use it for any kind of wireless ISDN
communication, but apparently there is little use for that without a physical
ISDN connection.
Arnd
Hi Arnd,
>>>>>>> When isdn4linux came up in the context of another patch series, I
>>>>>>> remembered that we had discussed removing it a while ago.
>>>>
>>>> NAK.
>>>>
>>>> I do not care about isdn4linux, but this is a purely CAPI based driver. So removing (or moving to staging)
>>>> CAPI support seems rather premature.
>>>>
>>>> Maybe someone would have started talking to us before trying to move this into staging. It is a
>>>> maintained driver. That it is rather simple and hasn’t seen patches in a long time, doesn’t mean
>>>> it is not maintained and staging material. I see no reason to tell any user to enable staging tree
>>>> to get CMTP support.
>>>
>>> I can definitely leave out the last patch from the series if we know
>>> that there are
>>> still users on CMTP. I searched around for a bit but could not find
>>> any indication
>>> what this is still used for, if anything.
>>
>> I would prefer if we leave CAPI support and with that CMTP mainstream and not move
>> that to staging. For isdn4linux, I have no objections to move that to staging since
>> mISDN was suppose to replace it anyway.
>
> Sure, I can rework the patch to leave the CAPI subsystem and only move the
> other three drivers (avm, hysdn, gigaset) into staging to see if
> anyone uses them.
awesome. Thanks.
>>> What I found were a couple of references of the driver no longer working
>>> about 10 years ago:
>>>
>>> https://wiki.ubuntuusers.de/Archiv/Bluetooth/BlueFritz%21/
>>> https://www.opensuse-forum.de/thread/2776-erledigt-suse-11-2-und-bluefritz/
>>>
>>> Is anyone using cmtp for voice or fax services? The use cases from before 2009
>>> that I could find were usually dial-up networking, but that seems pointless now
>>> if the only way to get an ISDN connection is to have it routed over
>>> the internet.
>>
>> I still have the hardware and last time I checked it worked just fine. However
>> you need to set up a proper pairing with the hardware. However that has nothing
>> to do with CMTP since that is just a CAPI message transport protocol.
>>
>> You can use it for voice and fax service as long as you have the right codecs in
>> place. At the end of the day CAPI is an API for ISDN. And CMTP just being a
>> transport, all ISDN services are possible given the right software / application.
>
> That does not answer my question. It's clear that you can do all those things
> with CAPI and CMTP, but what I was trying to find out is whether anyone still
> does.
>
> The gigaset driver is similar here, you can use it for any kind of wireless ISDN
> communication, but apparently there is little use for that without a physical
> ISDN connection.
You need a ISDN line or a telephone system that speaks ISDN via S0 bus. Consumer ISDN lines are pretty much extinct in Germany due to the movement towards all IP based DSL lines. However there are S0 busses on the Fritz!Boxes and you can just hang the CMTP capable gateways on the S0 bus. At least that is how I have this at home. If you asked me for what other people are still doing, I have no idea.
Regards
Marcel
Arnd Bergmann schreef op do 25-04-2019 om 13:08 [+0200]:
> The gigaset driver is similar here, you can use it for any kind of wireless ISDN
> communication,
Nit: the wireless part is strictly DECT (for the M101 and M105 hardware).
> but apparently there is little use for that without a physical
> ISDN connection.
Probably.
The main point is that once my ISDN line is canceled it would be nice to know
whether someone still cares about these drivers. (Do note that for day to day
data traffic I definitely do not really on ISDN. I'm not _that_ crazy.) Your
suggestion to exile them into drivers/staging is about the only policy we have
for finding that out.
Thanks,
Paul Bolle