2017-11-29 08:29:23

by ERAMOTO Masaya

Subject: [PATCH BlueZ] tools/obexctl: Fix display of size/time during transfer

When obexctl is run after starting to transfer a file, the transferred
size and the remaining time will be extreme values first as below:

[NEW] Transfer /org/bluez/obex/server/session8/transfer6
[CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1670741 (@1670KB/s 03:52)
[CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1703502 (@32KB/s 197:14)
[CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1736263 (@32KB/s 197:13)
---
tools/obexctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/obexctl.c b/tools/obexctl.c
index ece50f682..33ee180a3 100644
--- a/tools/obexctl.c
+++ b/tools/obexctl.c
@@ -2319,7 +2319,7 @@ static void transfer_added(GDBusProxy *proxy)

data = g_new0(struct transfer_data, 1);

- if (g_dbus_proxy_get_property(proxy, "Transfered", &iter))
+ if (g_dbus_proxy_get_property(proxy, "Transferred", &iter))
dbus_message_iter_get_basic(&iter, &data->transferred);

if (g_dbus_proxy_get_property(proxy, "Size", &iter))
--
2.14.1

2017-12-04 12:21:53

by Luiz Augusto von Dentz

Subject: Re: [PATCH BlueZ] tools/obexctl: Fix display of size/time during transfer

Hi Eramoto,

On Wed, Nov 29, 2017 at 10:29 AM, ERAMOTO Masaya
<[email protected]> wrote:
> When obexctl is run after starting to transfer a file, the transferred
> size and the remaining time will be extreme values first as below:
>
> [NEW] Transfer /org/bluez/obex/server/session8/transfer6
> [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1670741 (@1670KB/s 03:52)
> [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1703502 (@32KB/s 197:14)
> [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1736263 (@32KB/s 197:13)
> ---
> tools/obexctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/obexctl.c b/tools/obexctl.c
> index ece50f682..33ee180a3 100644
> --- a/tools/obexctl.c
> +++ b/tools/obexctl.c
> @@ -2319,7 +2319,7 @@ static void transfer_added(GDBusProxy *proxy)
>
> data = g_new0(struct transfer_data, 1);
>
> - if (g_dbus_proxy_get_property(proxy, "Transfered", &iter))
> + if (g_dbus_proxy_get_property(proxy, "Transferred", &iter))
> dbus_message_iter_get_basic(&iter, &data->transferred);
>
> if (g_dbus_proxy_get_property(proxy, "Size", &iter))
> --
> 2.14.1

Applied, thanks.

--
Luiz Augusto von Dentz