2017-08-25 14:21:40

by Bhumika Goyal

Subject: [PATCH 0/7] net: make some structures const

Make these const as they are not modified.

Bhumika Goyal (7):
Bluetooth: 6lowpan: make header_ops const
bridge: make ebt_table const
ieee802154: 6lowpan: make header_ops const
ipv4: make net_protocol const
RDS: make rhashtable_params const
netfilter: nat: make rhashtable_params const
SUNRPC: make kvec const

net/bluetooth/6lowpan.c | 2 +-
net/bridge/netfilter/ebtable_nat.c | 2 +-
net/ieee802154/6lowpan/core.c | 2 +-
net/ipv4/af_inet.c | 4 ++--
net/netfilter/nf_nat_core.c | 2 +-
net/rds/bind.c | 2 +-
net/sunrpc/xdr.c | 2 +-
7 files changed, 8 insertions(+), 8 deletions(-)

--
1.9.1

2017-08-25 16:17:21

by Marcel Holtmann

Subject: Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Hi Bhumika,

> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

2017-08-25 14:48:56

by Jeff Layton

Subject: Re: [PATCH 7/7] SUNRPC: make kvec const

On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> net/sunrpc/xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e34f4ee..a096025 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
> }
> EXPORT_SYMBOL_GPL(xdr_enter_page);
>
> -static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
> +static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
>
> void
> xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)

Reviewed-by: Jeff Layton <[email protected]>

2017-08-25 14:36:37

by Stefan Schmidt

Subject: Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Hello.

On 08/25/2017 04:21 PM, Bhumika Goyal wrote:
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index de2661c..974765b 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -54,7 +54,7 @@
>
> static int open_count;
>
> -static struct header_ops lowpan_header_ops = {
> +static const struct header_ops lowpan_header_ops = {
> .create = lowpan_header_create,
> };
>
>

Acked-by: Stefan Schmidt <[email protected]>

regards
Stefan Schmidt

2017-08-25 14:21:47

by Bhumika Goyal

Subject: [PATCH 7/7] SUNRPC: make kvec const

Make this const as it is only used during a copy operation.

Signed-off-by: Bhumika Goyal <[email protected]>
---
net/sunrpc/xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e34f4ee..a096025 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
}
EXPORT_SYMBOL_GPL(xdr_enter_page);

-static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
+static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};

void
xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
--
1.9.1

2017-08-25 14:21:46

by Bhumika Goyal

Subject: [PATCH 6/7] netfilter: nat: make rhashtable_params const

Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init.

Signed-off-by: Bhumika Goyal <[email protected]>
---
net/netfilter/nf_nat_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index b1d3740..df983ea 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -198,7 +198,7 @@ static int nf_nat_bysource_cmp(struct rhashtable_compare_arg *arg,
return 0;
}

-static struct rhashtable_params nf_nat_bysource_params = {
+static const struct rhashtable_params nf_nat_bysource_params = {
.head_offset = offsetof(struct nf_conn, nat_bysource),
.obj_hashfn = nf_nat_bysource_hash,
.obj_cmpfn = nf_nat_bysource_cmp,
--
1.9.1

2017-08-25 14:21:43

by Bhumika Goyal

Subject: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Make this const as it is only stored as a reference in a const field of
a net_device structure.

Signed-off-by: Bhumika Goyal <[email protected]>
---
net/ieee802154/6lowpan/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index de2661c..974765b 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -54,7 +54,7 @@

static int open_count;

-static struct header_ops lowpan_header_ops = {
+static const struct header_ops lowpan_header_ops = {
.create = lowpan_header_create,
};

--
1.9.1

2017-08-25 14:21:41

by Bhumika Goyal

Subject: [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const

Make this const as it is only stored as a reference in a const field of
a net_device structure.

Signed-off-by: Bhumika Goyal <[email protected]>
---
net/bluetooth/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 4e2576f..50fcdd1 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -581,7 +581,7 @@ static int bt_dev_init(struct net_device *dev)
.ndo_start_xmit = bt_xmit,
};

-static struct header_ops header_ops = {
+static const struct header_ops header_ops = {
.create = header_create,
};

--
1.9.1