2009-04-20 15:19:36

by alok barsode

[permalink] [raw]
Subject: [PATCH] Adding priority check for plugins.

Hi Marcel,

Adding priority field for plugins.
Let me know if anything needs modifications.

Cheers,
Alok.

Attachments:
0001-Add-priority-field-to-plugin-descriptor-definition-a.patch (6.48 kB)

2009-04-21 12:25:11

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Adding priority check for plugins.

Hi Alok,

no top posting. Ever.

> Modified patch attached.

Patch has been applied, but keep in mind that the 80 column rule is a
actually strict one.

Regards

Marcel



2009-04-21 11:41:10

by alok barsode

[permalink] [raw]
Subject: Re: [PATCH] Adding priority check for plugins.

Hi Marcel,

Modified patch attached.

On Tue, Apr 21, 2009 at 4:11 PM, Marcel Holtmann <[email protected]> wrote:
> Hi Alok,
>
>> >> modified patch attached.
>> >
>> > please to the line-break with BLUETOOTH_PLUGIN_DEFINE a little bit more
>> > like what ConnMan does so it looks nicer.
>> >
>> Infact i copied the syntax for BLUETOOTH_PLUGIN_DEFINE from the one in
>> connman. :D
>
> I meant the calls inside the plugins and not the definition itself.
>
> Regards
>
> Marcel
>
>
>

Attachments:
0001-Add-priority-field-to-plugin-descriptor-definition-a.patch (6.65 kB)

2009-04-21 10:41:40

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Adding priority check for plugins.

Hi Alok,

> >> modified patch attached.
> >
> > please to the line-break with BLUETOOTH_PLUGIN_DEFINE a little bit more
> > like what ConnMan does so it looks nicer.
> >
> Infact i copied the syntax for BLUETOOTH_PLUGIN_DEFINE from the one in
> connman. :D

I meant the calls inside the plugins and not the definition itself.

Regards

Marcel



2009-04-20 19:18:07

by alok barsode

[permalink] [raw]
Subject: Re: [PATCH] Adding priority check for plugins.

Hi Marcel,

On Mon, Apr 20, 2009 at 9:58 PM, Marcel Holtmann <[email protected]> wrote:
> Hi Alok,
>
>> modified patch attached.
>
> please to the line-break with BLUETOOTH_PLUGIN_DEFINE a little bit more
> like what ConnMan does so it looks nicer.
>
Infact i copied the syntax for BLUETOOTH_PLUGIN_DEFINE from the one in
connman. :D


#define CONNMAN_PLUGIN_DEFINE(name, description, version, priority,
init, exit) \
extern struct connman_plugin_desc connman_plugin_desc
\
__attribute__
((visibility("default"))); \
struct connman_plugin_desc connman_plugin_desc = { \
#name, description, version, priority, init,
exit \
};

#define BLUETOOTH_PLUGIN_DEFINE(name, version, priority, init, exit) \
extern struct bluetooth_plugin_desc
bluetooth_plugin_desc \
__attribute__
((visibility("default"))); \
struct bluetooth_plugin_desc bluetooth_plugin_desc = {
\
name, version, priority, init, exit \
};


> Regards
>
> Marcel
>
>
>

Cheers,
Alok.

2009-04-20 16:28:58

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Adding priority check for plugins.

Hi Alok,

> modified patch attached.

please to the line-break with BLUETOOTH_PLUGIN_DEFINE a little bit more
like what ConnMan does so it looks nicer.

Regards

Marcel



2009-04-20 15:52:11

by alok barsode

[permalink] [raw]
Subject: Re: [PATCH] Adding priority check for plugins.

Marcel,

modified patch attached.

Cheers,
Alok.

On Mon, Apr 20, 2009 at 9:01 PM, Marcel Holtmann <[email protected]> wrote:
> Hi Alok,
>
>> Adding priority field for plugins.
>> Let me know if anything needs modifications.
>
> please call it BLUETOOTH_PLUGIN_PRIORITY_* and break the plugin define
> lines properly.
>
> Regards
>
> Marcel
>
>
>

Attachments:
0001-Add-priority-field-to-plugin-descriptor-definition-a.patch (6.60 kB)

2009-04-20 15:31:15

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Adding priority check for plugins.

Hi Alok,

> Adding priority field for plugins.
> Let me know if anything needs modifications.

please call it BLUETOOTH_PLUGIN_PRIORITY_* and break the plugin define
lines properly.

Regards

Marcel