2019-09-26 09:24:59

by Amit K Bag

Subject: [PATCH] Bluetooth: btusb: print FW version after FW download

After FW download there is no print to confirm the current
FW version. Add print to check FW version incase of FW download.

Signed-off-by: Amit K Bag <[email protected]>
---
drivers/bluetooth/btusb.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a9c35ebb30f8..f6c033b5042c 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
*/
btintel_set_event_mask(hdev, false);

+ /* Read the Intel version information after loading the FW */
+ err = btintel_read_version(hdev, &ver);
+ if (err)
+ return err;
+
+ btintel_version_info(hdev, &ver);
+ bt_dev_info(hdev, "Setup complete");
+
return 0;
}

--
2.7.4

2019-09-26 10:20:23

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: btusb: print FW version after FW download

Hi Amit,

> After FW download there is no print to confirm the current
> FW version. Add print to check FW version incase of FW download.
>
> Signed-off-by: Amit K Bag <[email protected]>
> ---
> drivers/bluetooth/btusb.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index a9c35ebb30f8..f6c033b5042c 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
> */
> btintel_set_event_mask(hdev, false);
>
> + /* Read the Intel version information after loading the FW */
> + err = btintel_read_version(hdev, &ver);
> + if (err)
> + return err;
> +
> + btintel_version_info(hdev, &ver);
> + bt_dev_info(hdev, "Setup complete");
> +

I rather not add an extra Setup complete since that is rather noisy. We can add the extra version information if that adds value.

Regards

Marcel

2019-09-27 02:50:49

by Amit K Bag

Subject: RE: [PATCH] Bluetooth: btusb: print FW version after FW download

>Hi Amit,
>
>> After FW download there is no print to confirm the current FW version.
>> Add print to check FW version incase of FW download.
>>
>> Signed-off-by: Amit K Bag <[email protected]>
>> ---
>> drivers/bluetooth/btusb.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index a9c35ebb30f8..f6c033b5042c 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
>> */
>> btintel_set_event_mask(hdev, false);
>>
>> + /* Read the Intel version information after loading the FW */
>> + err = btintel_read_version(hdev, &ver);
>> + if (err)
>> + return err;
>> +
>> + btintel_version_info(hdev, &ver);
>> + bt_dev_info(hdev, "Setup complete");
>> +
>
>I rather not add an extra Setup complete since that is rather noisy. We can add the extra version information if that adds value.
>

I will remove this message and post the revised patch.