Mark the device as lost on device_lost_timeout so that it can be found
again next time.
Verified this by adding a monitor using bluetoothctl and confirming that
the DeviceLost event is getting triggered when bt peer stops advertising
and DeviceFound event gets triggered again when the bt peer restarts the
advertising.
Reviewed-by: Yun-Hao Chung <[email protected]>
---
src/adv_monitor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/adv_monitor.c b/src/adv_monitor.c
index 715ac5904..a55e1ea2d 100644
--- a/src/adv_monitor.c
+++ b/src/adv_monitor.c
@@ -1892,7 +1892,9 @@ static bool handle_device_lost_timeout(gpointer user_data)
g_dbus_proxy_method_call(monitor->proxy, "DeviceLost",
report_device_state_setup,
NULL, dev->device, NULL);
+
dev->lost_timer = 0;
+ dev->found = false;
return FALSE;
}
--
2.33.0.464.g1972c5931b-goog
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=550651
---Test result---
Test Summary:
CheckPatch PASS 1.37 seconds
GitLint FAIL 0.91 seconds
Prep - Setup ELL PASS 42.64 seconds
Build - Prep PASS 0.53 seconds
Build - Configure PASS 7.76 seconds
Build - Make PASS 190.42 seconds
Make Check PASS 9.55 seconds
Make Distcheck PASS 218.16 seconds
Build w/ext ELL - Configure PASS 7.83 seconds
Build w/ext ELL - Make PASS 174.00 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ,v1] adv_monitor: Mark the device as lost on device_lost_timeout
2: B4 Second line is not empty: "again next time."
---
Regards,
Linux Bluetooth
Hi Manish,
On Mon, Sep 27, 2021 at 11:30 AM Manish Mandlik <[email protected]> wrote:
>
> Friendly reminder to review this patch. :)
>
> Regards,
> Manish.
>
>
> On Tue, Sep 21, 2021 at 6:13 PM Manish Mandlik <[email protected]> wrote:
>>
>> Mark the device as lost on device_lost_timeout so that it can be found
>> again next time.
>>
>> Verified this by adding a monitor using bluetoothctl and confirming that
>> the DeviceLost event is getting triggered when bt peer stops advertising
>> and DeviceFound event gets triggered again when the bt peer restarts the
>> advertising.
>>
>> Reviewed-by: Yun-Hao Chung <[email protected]>
>> ---
>>
>> src/adv_monitor.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/src/adv_monitor.c b/src/adv_monitor.c
>> index 715ac5904..a55e1ea2d 100644
>> --- a/src/adv_monitor.c
>> +++ b/src/adv_monitor.c
>> @@ -1892,7 +1892,9 @@ static bool handle_device_lost_timeout(gpointer user_data)
>> g_dbus_proxy_method_call(monitor->proxy, "DeviceLost",
>> report_device_state_setup,
>> NULL, dev->device, NULL);
>> +
>> dev->lost_timer = 0;
>> + dev->found = false;
>>
>> return FALSE;
>> }
>> --
>> 2.33.0.464.g1972c5931b-goog
>>
Applied, thanks.
--
Luiz Augusto von Dentz