2020-07-22 09:08:46

by Laurent Bigonville

[permalink] [raw]
Subject: [PATCH] Also label polkit-agent-helper-1 when installed directly in /usr/libexec

From: Laurent Bigonville <[email protected]>

Debian now installs that executable directly in /usr/libexec for the
version 0.105

Signed-off-by: Laurent Bigonville <[email protected]>
---
policy/modules/services/policykit.fc | 1 +
1 file changed, 1 insertion(+)

diff --git a/policy/modules/services/policykit.fc b/policy/modules/services/policykit.fc
index e2782838..85814b95 100644
--- a/policy/modules/services/policykit.fc
+++ b/policy/modules/services/policykit.fc
@@ -11,6 +11,7 @@
# Systemd unit file
/usr/lib/systemd/system/[^/]*polkit.* -- gen_context(system_u:object_r:policykit_unit_t,s0)

+/usr/libexec/polkit-agent-helper-1 -- gen_context(system_u:object_r:policykit_auth_exec_t,s0)
/usr/libexec/polkit-read-auth-helper -- gen_context(system_u:object_r:policykit_auth_exec_t,s0)
/usr/libexec/polkit-grant-helper.* -- gen_context(system_u:object_r:policykit_grant_exec_t,s0)
/usr/libexec/polkit-resolve-exe-helper.* -- gen_context(system_u:object_r:policykit_resolve_exec_t,s0)
--
2.28.0.rc1


2020-07-22 09:15:49

by bauen1

[permalink] [raw]
Subject: Re: [PATCH] Also label polkit-agent-helper-1 when installed directly in /usr/libexec

Thanks,

See https://salsa.debian.org/utopia-team/polkit/-/commit/f6f99d85b2eb91bd03ca56d30837d7291711a0f8 for the change in the debian package.

On 7/22/20 10:59 AM, Laurent Bigonville wrote:
> From: Laurent Bigonville <[email protected]>
>
> Debian now installs that executable directly in /usr/libexec for the
> version 0.105
>
> Signed-off-by: Laurent Bigonville <[email protected]>
> ---
> policy/modules/services/policykit.fc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/policy/modules/services/policykit.fc b/policy/modules/services/policykit.fc
> index e2782838..85814b95 100644
> --- a/policy/modules/services/policykit.fc
> +++ b/policy/modules/services/policykit.fc
> @@ -11,6 +11,7 @@
> # Systemd unit file
> /usr/lib/systemd/system/[^/]*polkit.* -- gen_context(system_u:object_r:policykit_unit_t,s0)
>
> +/usr/libexec/polkit-agent-helper-1 -- gen_context(system_u:object_r:policykit_auth_exec_t,s0)

Since it is a debian only change, this should probably be wrapped in an ifdef distro_debian.

> /usr/libexec/polkit-read-auth-helper -- gen_context(system_u:object_r:policykit_auth_exec_t,s0)
> /usr/libexec/polkit-grant-helper.* -- gen_context(system_u:object_r:policykit_grant_exec_t,s0)
> /usr/libexec/polkit-resolve-exe-helper.* -- gen_context(system_u:object_r:policykit_resolve_exec_t,s0)
>
--
bauen1
https://dn42.bauen1.xyz/

2020-07-22 09:34:46

by Laurent Bigonville

[permalink] [raw]
Subject: Re: [PATCH] Also label polkit-agent-helper-1 when installed directly in /usr/libexec

Le 22/07/20 à 11:15, bauen1 a écrit :
> Thanks,
>
> See https://salsa.debian.org/utopia-team/polkit/-/commit/f6f99d85b2eb91bd03ca56d30837d7291711a0f8 for the change in the debian package.
>
> On 7/22/20 10:59 AM, Laurent Bigonville wrote:
>> From: Laurent Bigonville <[email protected]>
>>
>> Debian now installs that executable directly in /usr/libexec for the
>> version 0.105
>>
>> Signed-off-by: Laurent Bigonville <[email protected]>
>> ---
>> policy/modules/services/policykit.fc | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/policy/modules/services/policykit.fc b/policy/modules/services/policykit.fc
>> index e2782838..85814b95 100644
>> --- a/policy/modules/services/policykit.fc
>> +++ b/policy/modules/services/policykit.fc
>> @@ -11,6 +11,7 @@
>> # Systemd unit file
>> /usr/lib/systemd/system/[^/]*polkit.* -- gen_context(system_u:object_r:policykit_unit_t,s0)
>>
>> +/usr/libexec/polkit-agent-helper-1 -- gen_context(system_u:object_r:policykit_auth_exec_t,s0)
> Since it is a debian only change, this should probably be wrapped in an ifdef distro_debian.

In the past this was done like that, but at some point I've been told to
not use distro conditionals anymore. I can add it if you really want,
but in the last year(s) it was not done for the other file contexts that
were added.

>
>> /usr/libexec/polkit-read-auth-helper -- gen_context(system_u:object_r:policykit_auth_exec_t,s0)
>> /usr/libexec/polkit-grant-helper.* -- gen_context(system_u:object_r:policykit_grant_exec_t,s0)
>> /usr/libexec/polkit-resolve-exe-helper.* -- gen_context(system_u:object_r:policykit_resolve_exec_t,s0)
>>