2009-08-21 17:24:05

by Jan Kara

Subject: [PATCH 15/17] nfs: Remove reference to generic_osync_inode from a comment

generic_file_direct_write() no longer calls generic_osync_inode() so remove the
comment.

CC: [email protected]
CC: Neil Brown <[email protected]>
CC: "J. Bruce Fields" <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
---
fs/nfs/direct.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 489fc01..fd5fcc9 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -934,9 +934,6 @@ out:
* back into its cache. We let the server do generic write
* parameter checking and report problems.
*
- * We also avoid an unnecessary invocation of generic_osync_inode(),
- * as it is fairly meaningless to sync the metadata of an NFS file.
- *
* We eliminate local atime updates, see direct read above.
*
* We avoid unnecessary page cache invalidations for normal cached
--
1.6.0.2

2009-08-21 17:52:04

by Trond Myklebust

Subject: Re: [PATCH 15/17] nfs: Remove reference to generic_osync_inode from a comment

On Fri, 2009-08-21 at 19:24 +0200, Jan Kara wrote:
> generic_file_direct_write() no longer calls generic_osync_inode() so remove the
> comment.

Thanks. I've applied it to the nfs-for-2.6.32 branch.

Cheers
Trond