2009-09-08 22:17:43

by Trond Myklebust

[permalink] [raw]
Subject: Re: [PATCH 4/4] NFS: Allow the "nfs" file system type to support NFSv4

On Wed, 2009-09-02 at 09:52 -0400, Chuck Lever wrote:
> When mounting an "nfs" type file system, recognize "v4," "vers=4," or
> "nfsvers=4" mount options, and convert the file system to "nfs4" under
> the covers.
>
> Signed-off-by: Chuck Lever <[email protected]>
> ---

For consistency, can we please ensure that we set the
nfs_parsed_mount_data->version in the binary mount case too?

The other thing to note is that we should not allow vers=2,3 in the -t
nfs4 case.

I'll fix the former inline in your patch 4/4, and add the latter as a
separate patch.

Cheers
Trond