2009-09-24 12:19:59

by Jaswinder Singh Rajput

Subject: [PATCH] net: fix htmldocs sunrpc, clnt.c

DOCPROC Documentation/DocBook/networking.xml
Warning(net/sunrpc/clnt.c:647): No description found for parameter 'req'
Warning(net/sunrpc/clnt.c:647): No description found for parameter 'tk_ops'
Warning(net/sunrpc/clnt.c:647): Excess function parameter 'ops' description in 'rpc_run_bc_task'

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Cc: Ricardo Labiaga <[email protected]>
Cc: Benny Halevy <[email protected]>
Cc: Andy Adamson <[email protected]>
Cc: Trond Myklebust <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: David Miller <[email protected]>
---
net/sunrpc/clnt.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index a417d5a..38829e2 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -640,10 +640,11 @@ EXPORT_SYMBOL_GPL(rpc_call_async);
/**
* rpc_run_bc_task - Allocate a new RPC task for backchannel use, then run
* rpc_execute against it
- * @ops: RPC call ops
+ * @req: RPC request
+ * @tk_ops: RPC call ops
*/
struct rpc_task *rpc_run_bc_task(struct rpc_rqst *req,
- const struct rpc_call_ops *tk_ops)
+ const struct rpc_call_ops *tk_ops)
{
struct rpc_task *task;
struct xdr_buf *xbufp = &req->rq_snd_buf;
--
1.6.0.6

2009-09-24 16:19:42

by Randy Dunlap

Subject: Re: [PATCH] net: fix htmldocs sunrpc, clnt.c

Jaswinder Singh Rajput wrote:
> DOCPROC Documentation/DocBook/networking.xml
> Warning(net/sunrpc/clnt.c:647): No description found for parameter 'req'
> Warning(net/sunrpc/clnt.c:647): No description found for parameter 'tk_ops'
> Warning(net/sunrpc/clnt.c:647): Excess function parameter 'ops' description in 'rpc_run_bc_task'
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Ack. Already sent, but possibly lost.

> Cc: Ricardo Labiaga <[email protected]>
> Cc: Benny Halevy <[email protected]>
> Cc: Andy Adamson <[email protected]>
> Cc: Trond Myklebust <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: David Miller <[email protected]>
> ---
> net/sunrpc/clnt.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index a417d5a..38829e2 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -640,10 +640,11 @@ EXPORT_SYMBOL_GPL(rpc_call_async);
> /**
> * rpc_run_bc_task - Allocate a new RPC task for backchannel use, then run
> * rpc_execute against it
> - * @ops: RPC call ops
> + * @req: RPC request
> + * @tk_ops: RPC call ops
> */
> struct rpc_task *rpc_run_bc_task(struct rpc_rqst *req,
> - const struct rpc_call_ops *tk_ops)
> + const struct rpc_call_ops *tk_ops)
> {
> struct rpc_task *task;
> struct xdr_buf *xbufp = &req->rq_snd_buf;

2009-09-24 16:46:06

by Benny Halevy

Subject: Re: [PATCH] net: fix htmldocs sunrpc, clnt.c

On Sep. 24, 2009, 19:19 +0300, Randy Dunlap <[email protected]> wrote:
> Jaswinder Singh Rajput wrote:
>> DOCPROC Documentation/DocBook/networking.xml
>> Warning(net/sunrpc/clnt.c:647): No description found for parameter 'req'
>> Warning(net/sunrpc/clnt.c:647): No description found for parameter 'tk_ops'
>> Warning(net/sunrpc/clnt.c:647): Excess function parameter 'ops' description in 'rpc_run_bc_task'
>>
>> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
>
> Ack. Already sent, but possibly lost.

Ack. thanks!

>
>> Cc: Ricardo Labiaga <[email protected]>
>> Cc: Benny Halevy <[email protected]>
>> Cc: Andy Adamson <[email protected]>
>> Cc: Trond Myklebust <[email protected]>
>> Cc: Randy Dunlap <[email protected]>
>> Cc: David Miller <[email protected]>
>> ---
>> net/sunrpc/clnt.c | 5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
>> index a417d5a..38829e2 100644
>> --- a/net/sunrpc/clnt.c
>> +++ b/net/sunrpc/clnt.c
>> @@ -640,10 +640,11 @@ EXPORT_SYMBOL_GPL(rpc_call_async);
>> /**
>> * rpc_run_bc_task - Allocate a new RPC task for backchannel use, then run
>> * rpc_execute against it
>> - * @ops: RPC call ops
>> + * @req: RPC request
>> + * @tk_ops: RPC call ops
>> */
>> struct rpc_task *rpc_run_bc_task(struct rpc_rqst *req,
>> - const struct rpc_call_ops *tk_ops)
>> + const struct rpc_call_ops *tk_ops)
>> {
>> struct rpc_task *task;
>> struct xdr_buf *xbufp = &req->rq_snd_buf;
>

2009-09-24 22:46:10

by David Miller

Subject: Re: [PATCH] net: fix htmldocs sunrpc, clnt.c

From: Randy Dunlap <[email protected]>
Date: Thu, 24 Sep 2009 09:19:35 -0700

> Jaswinder Singh Rajput wrote:
>> DOCPROC Documentation/DocBook/networking.xml
>> Warning(net/sunrpc/clnt.c:647): No description found for parameter 'req'
>> Warning(net/sunrpc/clnt.c:647): No description found for parameter 'tk_ops'
>> Warning(net/sunrpc/clnt.c:647): Excess function parameter 'ops' description in 'rpc_run_bc_task'
>>
>> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
>
> Ack. Already sent, but possibly lost.

Applied.