2009-10-04 19:06:43

by Trond Myklebust

[permalink] [raw]
Subject: Re: [Bug 14276] nfsroot will not remount rw and claims illegal options

On Sun, 2009-10-04 at 17:48 +0000, bugzilla-daemon-590EEB7GvNiWaY/[email protected]
wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=14276
>
>
>
>
>
> --- Comment #6 from Hans de Bruin <bruinjm-qWit8jRvyhVmR6Xm/[email protected]> 2009-10-04 17:48:57 ---
> hans@orion:/var/diskless/kernel/linux-2.6$ git bisect bad
> 53a0b9c4c99ab0085a06421f71592722e5b3fd5f is first bad commit
> commit 53a0b9c4c99ab0085a06421f71592722e5b3fd5f
> Author: Chuck Lever <[email protected]>
> Date: Sun Aug 9 15:09:36 2009 -0400
>
> NFS: Replace nfs_parse_ip_address() with rpc_pton()
>
> Clean up: Use the common routine now provided in sunrpc.ko for parsing
> mount
> addresses.
>
> Signed-off-by: Chuck Lever <[email protected]>
> Signed-off-by: Trond Myklebust <[email protected]>
>
> :040000 040000 31c3998309b2c325b7ea927498e1a7e78e0e7747
> 513edbc936111eda9d1646db17e7240c77a32c42 M fs
> hans@orion:/var/diskless/kernel/linux-2.6$

OK. Switching over to email.

Chuck, can you see how the rpc_pton() might be breaking nfsroot?
The cmdline is of the form

root=/dev/nfs nfsroot=10.10.0.2:/nfs/gemini,v3,tcp ro ip=::::::dhcp

Cheers
Trond