2009-11-28 15:30:17

by Trond Myklebust

[permalink] [raw]
Subject: Re: Fw: Deadlock regression in v2.6.31.6

On Sat, 2009-11-28 at 01:20 +0100, Stephen R. van den Berg wrote:
> On Fri, Nov 27, 2009 at 22:23, Trond Myklebust
> <[email protected]> wrote:
> > On Fri, 2009-11-27 at 01:14 +0100, Stephen R. van den Berg wrote:
> >> On Fri, Nov 27, 2009 at 01:07, Stephen R. van den Berg <[email protected]> wrote:
> > Does the following patch fix matters?
>
> > if (!xprt_lock_write(xprt, task))
> > return;
> > +
> > + if (test_and_clear_bit(XPRT_CLOSE_WAIT, &xprt->state))
> > + xprt->ops->close(xprt);
> > +
> > if (xprt_connected(xprt))
>
> Sorry. No go. I got the following trace, I'm not sure if this is
> relevant, because it is difficult to determine if the logging
> corresponds to the experienced problem.
>
> RPC: 14194 xprt_connect_status: retrying
> RPC: 14194 xprt_prepare_transmit
> RPC: 14194 xprt_transmit(112)
> RPC: disconnected transport cfa82400
> RPC: 14194 xprt_connect xprt cfa82400 is not connected
> RPC: 14194 xprt_connect_status: retrying
> RPC: 14194 xprt_prepare_transmit
> RPC: 14194 xprt_transmit(112)
> RPC: disconnected transport cfa82400
> RPC: 14194 xprt_connect xprt cfa82400 is not connected
> RPC: 14194 xprt_connect_status: retrying
> RPC: 14194 xprt_prepare_transmit
> RPC: 14194 xprt_transmit(112)
> RPC: disconnected transport cfa82400
> RPC: 14194 xprt_connect xprt cfa82400 is not connected
> RPC: 14194 xprt_connect_status: retrying
> RPC: 14194 xprt_prepare_transmit
> RPC: 14194 xprt_transmit(112)
> RPC: disconnected transport cfa82400
> RPC: 14194 xprt_connect xprt cfa82400 is not connected
> RPC: 14194 xprt_connect_status: retrying
> RPC: 14194 xprt_prepare_transmit
> RPC: 14194 xprt_transmit(112)

Did anything change w.r.t. the RPCDBG_TRANS (or better still - the
RPCDBG_XPRT|RPCDBG_TRANS) trace?

Trond