2010-05-20 13:47:20

by Trond Myklebust

[permalink] [raw]
Subject: Re: [PATCH] nfs: avoid possible deadlock bug when setting up delegation.

On Thu, 2010-05-20 at 21:20 +0800, Tao Guo wrote:
> On Thu, May 20, 2010 at 8:57 PM, Trond Myklebust
> <[email protected]> wrote:
> > On Thu, 2010-05-20 at 13:42 +0800, Tao Guo wrote:
> >> Unlock clp->cl_lock before taking inode->i_lock when setting up
> >> delegation to avoid possible deadlock bug.
> >
> > What deadlock? inode->i_lock should always be the innermost lock, so it
> > should always be safe to take it while already holding the nfs_client
> > lock.
> here is: http://marc.info/?l=linux-nfs&m=127424502009958&w=2
> >

That would be a pnfs bug... Please fix it so that it adheres to the
locking rules in mainline.

Trond