2011-02-22 16:07:35

by Mkrtchyan, Tigran

Subject: [PATCH] nfsd: fix missing include

I got some compile time error:

CC [M] fs/nfsd/nfs4proc.o
In file included from include/linux/nfsd/nfsd4_pnfs.h:39:0,
from include/linux/nfsd/nfs4layoutxdr.h:38,
from fs/nfsd/nfs4proc.c:37:
include/linux/nfs_xdr.h:1124:15: error: field ‘refcount’ has incomplete type

and here is my attempt to fix it
---
include/linux/nfs_xdr.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
index a965f9d..e4710b0 100644
--- a/include/linux/nfs_xdr.h
+++ b/include/linux/nfs_xdr.h
@@ -5,6 +5,7 @@
#include <linux/nfs3.h>
#include <linux/nfs4.h>
#include <linux/sunrpc/sched.h>
+#include <linux/kref.h>

/*
* To change the maximum rsize and wsize supported by the NFS client, adjust
--
1.7.4

2011-02-22 17:08:06

by Benny Halevy

Subject: Re: [PATCH] nfsd: fix missing include

Thanks. This pnfs specific, introduced in
c857ea8 pnfs_submit: signal layoutdriver commit

I'll fix it there...

Benny

On 2011-02-22 08:08, Tigran Mkrtchyan wrote:
> I got some compile time error:
>
> CC [M] fs/nfsd/nfs4proc.o
> In file included from include/linux/nfsd/nfsd4_pnfs.h:39:0,
> from include/linux/nfsd/nfs4layoutxdr.h:38,
> from fs/nfsd/nfs4proc.c:37:
> include/linux/nfs_xdr.h:1124:15: error: field ‘refcount’ has incomplete type
>
> and here is my attempt to fix it
> ---
> include/linux/nfs_xdr.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
> index a965f9d..e4710b0 100644
> --- a/include/linux/nfs_xdr.h
> +++ b/include/linux/nfs_xdr.h
> @@ -5,6 +5,7 @@
> #include <linux/nfs3.h>
> #include <linux/nfs4.h>
> #include <linux/sunrpc/sched.h>
> +#include <linux/kref.h>
>
> /*
> * To change the maximum rsize and wsize supported by the NFS client, adjust