2011-10-27 18:43:08

by Benny Halevy

Subject: [PATCH] nfsd4: typo logical vs bitwise negate in nfsd4_decode_share_access

From: Benny Halevy <[email protected]>

Signed-off-by: Benny Halevy <[email protected]>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 66d095d..b6fa792 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -655,7 +655,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
default:
return nfserr_bad_xdr;
}
- w &= !NFS4_SHARE_ACCESS_MASK;
+ w &= ~NFS4_SHARE_ACCESS_MASK;
if (!w)
return nfs_ok;
if (!argp->minorversion)
--
1.7.6

2011-10-28 10:02:07

by J. Bruce Fields

Subject: Re: [PATCH] nfsd4: typo logical vs bitwise negate in nfsd4_decode_share_access

Oh cripes, another one. Thanks for catching this one too.

--b.

On Thu, Oct 27, 2011 at 08:43:01PM +0200, Benny Halevy wrote:
> From: Benny Halevy <[email protected]>
>
> Signed-off-by: Benny Halevy <[email protected]>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 66d095d..b6fa792 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -655,7 +655,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
> default:
> return nfserr_bad_xdr;
> }
> - w &= !NFS4_SHARE_ACCESS_MASK;
> + w &= ~NFS4_SHARE_ACCESS_MASK;
> if (!w)
> return nfs_ok;
> if (!argp->minorversion)
> --
> 1.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html