2012-02-17 14:53:01

by Harshula

[permalink] [raw]
Subject: [PATCH] nfs-utils: exports man page: no_acl is not supported

The inclusion of no_acl in the exports man page is confusing since it is
not actually supported (v3.3-rc3):

1090 static struct flags {
1091 int flag;
1092 char *name[2];
1093 } expflags[] = {
1094 { NFSEXP_READONLY, {"ro", "rw"}},
1095 { NFSEXP_INSECURE_PORT, {"insecure", ""}},
1096 { NFSEXP_ROOTSQUASH, {"root_squash", "no_root_squash"}},
1097 { NFSEXP_ALLSQUASH, {"all_squash", ""}},
1098 { NFSEXP_ASYNC, {"async", "sync"}},
1099 { NFSEXP_GATHERED_WRITES, {"wdelay", "no_wdelay"}},
1100 { NFSEXP_NOHIDE, {"nohide", ""}},
1101 { NFSEXP_CROSSMOUNT, {"crossmnt", ""}},
1102 { NFSEXP_NOSUBTREECHECK, {"no_subtree_check", ""}},
1103 { NFSEXP_NOAUTHNLM, {"insecure_locks", ""}},
1104 { NFSEXP_V4ROOT, {"v4root", ""}},
1105 { 0, {"", ""}}
1106 };

Signed-off-by: Harshula Jayasuriya <[email protected]>
Acked-by: J. Bruce Fields <[email protected]>
---
utils/exportfs/exports.man | 18 ------------------
1 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/utils/exportfs/exports.man b/utils/exportfs/exports.man
index 54adfeb..bc1de73 100644
--- a/utils/exportfs/exports.man
+++ b/utils/exportfs/exports.man
@@ -293,24 +293,6 @@ be explicitly requested with either of the synonymous
.IR auth_nlm ,
or
.IR secure_locks .
-.TP
-.IR no_acl
-On some specially patched kernels, and when exporting filesystems that
-support ACLs, this option tells
-.B nfsd
-not to reveal ACLs to clients, so
-they will see only a subset of actual permissions on the given file
-system. This option is safe for filesystems used by NFSv2 clients and
-old NFSv3 clients that perform access decisions locally. Current
-NFSv3 clients use the ACCESS RPC to perform all access decisions on
-the server. Note that the
-.I no_acl
-option only has effect on kernels specially patched to support it, and
-when exporting filesystems with ACL support. The default is to export
-with ACL support (i.e. by default,
-.I no_acl
-is off).
-
.\".TP
.\".I noaccess
.\"This makes everything below the directory inaccessible for the named
--
1.7.7.6



2012-02-29 20:43:04

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: exports man page: no_acl is not supported



On 02/17/2012 09:52 AM, Harshula Jayasuriya wrote:
> The inclusion of no_acl in the exports man page is confusing since it is
> not actually supported (v3.3-rc3):
>
> 1090 static struct flags {
> 1091 int flag;
> 1092 char *name[2];
> 1093 } expflags[] = {
> 1094 { NFSEXP_READONLY, {"ro", "rw"}},
> 1095 { NFSEXP_INSECURE_PORT, {"insecure", ""}},
> 1096 { NFSEXP_ROOTSQUASH, {"root_squash", "no_root_squash"}},
> 1097 { NFSEXP_ALLSQUASH, {"all_squash", ""}},
> 1098 { NFSEXP_ASYNC, {"async", "sync"}},
> 1099 { NFSEXP_GATHERED_WRITES, {"wdelay", "no_wdelay"}},
> 1100 { NFSEXP_NOHIDE, {"nohide", ""}},
> 1101 { NFSEXP_CROSSMOUNT, {"crossmnt", ""}},
> 1102 { NFSEXP_NOSUBTREECHECK, {"no_subtree_check", ""}},
> 1103 { NFSEXP_NOAUTHNLM, {"insecure_locks", ""}},
> 1104 { NFSEXP_V4ROOT, {"v4root", ""}},
> 1105 { 0, {"", ""}}
> 1106 };
>
> Signed-off-by: Harshula Jayasuriya <[email protected]>
> Acked-by: J. Bruce Fields <[email protected]>
Committed... sorry it too so long...

steved.

> ---
> utils/exportfs/exports.man | 18 ------------------
> 1 files changed, 0 insertions(+), 18 deletions(-)
>
> diff --git a/utils/exportfs/exports.man b/utils/exportfs/exports.man
> index 54adfeb..bc1de73 100644
> --- a/utils/exportfs/exports.man
> +++ b/utils/exportfs/exports.man
> @@ -293,24 +293,6 @@ be explicitly requested with either of the synonymous
> .IR auth_nlm ,
> or
> .IR secure_locks .
> -.TP
> -.IR no_acl
> -On some specially patched kernels, and when exporting filesystems that
> -support ACLs, this option tells
> -.B nfsd
> -not to reveal ACLs to clients, so
> -they will see only a subset of actual permissions on the given file
> -system. This option is safe for filesystems used by NFSv2 clients and
> -old NFSv3 clients that perform access decisions locally. Current
> -NFSv3 clients use the ACCESS RPC to perform all access decisions on
> -the server. Note that the
> -.I no_acl
> -option only has effect on kernels specially patched to support it, and
> -when exporting filesystems with ACL support. The default is to export
> -with ACL support (i.e. by default,
> -.I no_acl
> -is off).
> -
> .\".TP
> .\".I noaccess
> .\"This makes everything below the directory inaccessible for the named
> -- 1.7.7.6
>