2012-05-16 08:35:44

by Benny Halevy

[permalink] [raw]
Subject: [PATCH] NFS: fix unsigned comparison in nfs4_create_sec_client

fs/nfs/nfs4namespace.c: In function ‘nfs4_create_sec_client’:
fs/nfs/nfs4namespace.c:171:2: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]

Introduced by commit 72de53ec4bca39c26709122a8f78bfefe7b6bca4
"NFS: Do secinfo as part of lookup"

Signed-off-by: Benny Halevy <[email protected]>
---
fs/nfs/nfs4namespace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c
index a7f3ded..3f5519b 100644
--- a/fs/nfs/nfs4namespace.c
+++ b/fs/nfs/nfs4namespace.c
@@ -168,7 +168,7 @@ struct rpc_clnt *nfs4_create_sec_client(struct rpc_clnt *clnt, struct inode *ino
rpc_authflavor_t flavor;

flavor = nfs4_negotiate_security(inode, name);
- if (flavor < 0)
+ if ((int)flavor < 0)
return ERR_PTR(flavor);

clone = rpc_clone_client(clnt);
--
1.7.6.5