2013-02-04 17:51:24

by Jeff Layton

Subject: [PATCH] sunrpc: fix comment in struct xdr_buf definition

...these pages aren't necessarily contiguous.

Signed-off-by: Jeff Layton <[email protected]>
---
include/linux/sunrpc/xdr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/sunrpc/xdr.h b/include/linux/sunrpc/xdr.h
index 6398899..224d060 100644
--- a/include/linux/sunrpc/xdr.h
+++ b/include/linux/sunrpc/xdr.h
@@ -56,7 +56,7 @@ struct xdr_buf {
struct kvec head[1], /* RPC header + non-page data */
tail[1]; /* Appended after page data */

- struct page ** pages; /* Array of contiguous pages */
+ struct page ** pages; /* Array of pages */
unsigned int page_base, /* Start of page data */
page_len, /* Length of page data */
flags; /* Flags for data disposition */
--
1.7.11.7

2013-02-04 18:12:46

by J. Bruce Fields

Subject: Re: [PATCH] sunrpc: fix comment in struct xdr_buf definition

On Mon, Feb 04, 2013 at 12:51:17PM -0500, Jeff Layton wrote:
> ...these pages aren't necessarily contiguous.

I guess you could say it was correct if you took "contiguous" to mean
that the xdr data they hold is meant to be contiguous.

But, yeah, at best I can't see how that comment would help anyone.

Applying absent any objections.

--b.

>
> Signed-off-by: Jeff Layton <[email protected]>
> ---
> include/linux/sunrpc/xdr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/sunrpc/xdr.h b/include/linux/sunrpc/xdr.h
> index 6398899..224d060 100644
> --- a/include/linux/sunrpc/xdr.h
> +++ b/include/linux/sunrpc/xdr.h
> @@ -56,7 +56,7 @@ struct xdr_buf {
> struct kvec head[1], /* RPC header + non-page data */
> tail[1]; /* Appended after page data */
>
> - struct page ** pages; /* Array of contiguous pages */
> + struct page ** pages; /* Array of pages */
> unsigned int page_base, /* Start of page data */
> page_len, /* Length of page data */
> flags; /* Flags for data disposition */
> --
> 1.7.11.7
>