2014-02-28 21:06:13

by Aaro Koskinen

[permalink] [raw]
Subject: [PATCH nfs-utils] tools: use install -m instead of --mode

Use install -m instead of--mode for better compatibility.
E.g. busybox's install doesn't support the long option.

Signed-off-by: Aaro Koskinen <[email protected]>
---
tools/mountstats/Makefile.am | 2 +-
tools/nfs-iostat/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/mountstats/Makefile.am b/tools/mountstats/Makefile.am
index ca617a2..c2e9f99 100644
--- a/tools/mountstats/Makefile.am
+++ b/tools/mountstats/Makefile.am
@@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
all-local: $(PYTHON_FILES)

install-data-hook:
- $(INSTALL) --mode 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
+ $(INSTALL) -m 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats

MAINTAINERCLEANFILES=Makefile.in
diff --git a/tools/nfs-iostat/Makefile.am b/tools/nfs-iostat/Makefile.am
index 30f4054..3ae0f29 100644
--- a/tools/nfs-iostat/Makefile.am
+++ b/tools/nfs-iostat/Makefile.am
@@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
all-local: $(PYTHON_FILES)

install-data-hook:
- $(INSTALL) --mode 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
+ $(INSTALL) -m 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat

MAINTAINERCLEANFILES=Makefile.in
--
1.8.3.3



2014-03-11 19:07:32

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH nfs-utils] tools: use install -m instead of --mode



On 02/28/2014 04:06 PM, Aaro Koskinen wrote:
> Use install -m instead of--mode for better compatibility.
> E.g. busybox's install doesn't support the long option.
>
> Signed-off-by: Aaro Koskinen <[email protected]>
Committed...

steved.

> ---
> tools/mountstats/Makefile.am | 2 +-
> tools/nfs-iostat/Makefile.am | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/mountstats/Makefile.am b/tools/mountstats/Makefile.am
> index ca617a2..c2e9f99 100644
> --- a/tools/mountstats/Makefile.am
> +++ b/tools/mountstats/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
> all-local: $(PYTHON_FILES)
>
> install-data-hook:
> - $(INSTALL) --mode 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
> + $(INSTALL) -m 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
>
> MAINTAINERCLEANFILES=Makefile.in
> diff --git a/tools/nfs-iostat/Makefile.am b/tools/nfs-iostat/Makefile.am
> index 30f4054..3ae0f29 100644
> --- a/tools/nfs-iostat/Makefile.am
> +++ b/tools/nfs-iostat/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
> all-local: $(PYTHON_FILES)
>
> install-data-hook:
> - $(INSTALL) --mode 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
> + $(INSTALL) -m 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
>
> MAINTAINERCLEANFILES=Makefile.in
>