2014-06-20 17:30:35

by Anna Schumaker

Subject: [PATCH] nfs: Fix unused variable error

inode is unused when CONFIG_SUNRPC_DEBUG=n.

Signed-off-by: Anna Schumaker <[email protected]>
---
fs/nfs/pagelist.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 8143d6b..6e2c0bc 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -552,7 +552,6 @@ static void nfs_pgio_prepare(struct rpc_task *task, void *calldata)
int nfs_initiate_pgio(struct rpc_clnt *clnt, struct nfs_pgio_header *hdr,
const struct rpc_call_ops *call_ops, int how, int flags)
{
- struct inode *inode = hdr->inode;
struct rpc_task *task;
struct rpc_message msg = {
.rpc_argp = &hdr->args,
@@ -575,8 +574,8 @@ int nfs_initiate_pgio(struct rpc_clnt *clnt, struct nfs_pgio_header *hdr,
dprintk("NFS: %5u initiated pgio call "
"(req %s/%llu, %u bytes @ offset %llu)\n",
hdr->task.tk_pid,
- inode->i_sb->s_id,
- (unsigned long long)NFS_FILEID(inode),
+ hdr->inode->i_sb->s_id,
+ (unsigned long long)NFS_FILEID(hdr->inode),
hdr->args.count,
(unsigned long long)hdr->args.offset);

--
2.0.0

2014-06-20 17:49:50

by Trond Myklebust

Subject: Re: [PATCH] nfs: Fix unused variable error

On Fri, Jun 20, 2014 at 1:30 PM, Anna Schumaker
<[email protected]> wrote:
> inode is unused when CONFIG_SUNRPC_DEBUG=n.
>

Thanks!

--
Trond Myklebust

Linux NFS client maintainer, PrimaryData

[email protected]