2014-07-10 15:53:37

by Srikrishan Malik

Subject: [PATCH] Use original reserved port setting for reconnect.

Signed-off-by: Srikrishan Malik <[email protected]>
---
Reconnect ignores the "--secure" arg after connection reset.
If the export is secure then OPs after reconnect fail with NFS4ERR_ACCESS.
nfs4.0/lib/rpc/rpc.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/nfs4.0/lib/rpc/rpc.py b/nfs4.0/lib/rpc/rpc.py
index 8b39df4..5ef2e3e 100644
--- a/nfs4.0/lib/rpc/rpc.py
+++ b/nfs4.0/lib/rpc/rpc.py
@@ -305,7 +305,8 @@ class RPCClient(object):
self.lock.acquire()
self._socket[t].close()
out = self._socket[t] = socket.socket(self.af, socket.SOCK_STREAM)
- # out.bind
+ if self.uselowport:
+ self.bindsocket(out)
out.connect((self.remotehost, self.remoteport))
out.settimeout(self.timeout)
self.lock.release()
--
1.7.1

2014-07-11 19:24:18

by J. Bruce Fields

Subject: Re: [PATCH] Use original reserved port setting for reconnect.

Thanks, applying.--b.

On Thu, Jul 10, 2014 at 09:22:06PM +0530, Srikrishan Malik wrote:
> Signed-off-by: Srikrishan Malik <[email protected]>
> ---
> Reconnect ignores the "--secure" arg after connection reset.
> If the export is secure then OPs after reconnect fail with NFS4ERR_ACCESS.
> nfs4.0/lib/rpc/rpc.py | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/nfs4.0/lib/rpc/rpc.py b/nfs4.0/lib/rpc/rpc.py
> index 8b39df4..5ef2e3e 100644
> --- a/nfs4.0/lib/rpc/rpc.py
> +++ b/nfs4.0/lib/rpc/rpc.py
> @@ -305,7 +305,8 @@ class RPCClient(object):
> self.lock.acquire()
> self._socket[t].close()
> out = self._socket[t] = socket.socket(self.af, socket.SOCK_STREAM)
> - # out.bind
> + if self.uselowport:
> + self.bindsocket(out)
> out.connect((self.remotehost, self.remoteport))
> out.settimeout(self.timeout)
> self.lock.release()
> --
> 1.7.1
>