2014-09-25 20:55:56

by Trond Myklebust

Subject: [PATCH] NFSv3: Fix missing includes of nfs3_fs.h

Silence a few warnings about missing symbols that are due to missing
includes of nfs3_fs.h.

Fixes: 00a36a1090350 (NFS: Move v3 declarations out of internal.h)
Fixes: cb8c20fa53ec2 (NFS: Move NFS v3 acl functions to nfs3_fs.h)
Signed-off-by: Trond Myklebust <[email protected]>
---
fs/nfs/nfs3acl.c | 1 +
fs/nfs/nfs3client.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c
index 24c6898159cc..658e586ca438 100644
--- a/fs/nfs/nfs3acl.c
+++ b/fs/nfs/nfs3acl.c
@@ -7,6 +7,7 @@
#include <linux/nfsacl.h>

#include "internal.h"
+#include "nfs3_fs.h"

#define NFSDBG_FACILITY NFSDBG_PROC

diff --git a/fs/nfs/nfs3client.c b/fs/nfs/nfs3client.c
index b3fc65ef39ca..8c1b437c5403 100644
--- a/fs/nfs/nfs3client.c
+++ b/fs/nfs/nfs3client.c
@@ -1,6 +1,7 @@
#include <linux/nfs_fs.h>
#include <linux/nfs_mount.h>
#include "internal.h"
+#include "nfs3_fs.h"

#ifdef CONFIG_NFS_V3_ACL
static struct rpc_stat nfsacl_rpcstat = { &nfsacl_program };
--
1.9.3

2014-09-25 21:01:23

by Anna Schumaker

Subject: Re: [PATCH] NFSv3: Fix missing includes of nfs3_fs.h

Looks good to me, although I'm not sure how I missed that when I submitted my patches!

Anna

On 09/25/2014 04:55 PM, Trond Myklebust wrote:
> Silence a few warnings about missing symbols that are due to missing
> includes of nfs3_fs.h.
>
> Fixes: 00a36a1090350 (NFS: Move v3 declarations out of internal.h)
> Fixes: cb8c20fa53ec2 (NFS: Move NFS v3 acl functions to nfs3_fs.h)
> Signed-off-by: Trond Myklebust <[email protected]>
> ---
> fs/nfs/nfs3acl.c | 1 +
> fs/nfs/nfs3client.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c
> index 24c6898159cc..658e586ca438 100644
> --- a/fs/nfs/nfs3acl.c
> +++ b/fs/nfs/nfs3acl.c
> @@ -7,6 +7,7 @@
> #include <linux/nfsacl.h>
>
> #include "internal.h"
> +#include "nfs3_fs.h"
>
> #define NFSDBG_FACILITY NFSDBG_PROC
>
> diff --git a/fs/nfs/nfs3client.c b/fs/nfs/nfs3client.c
> index b3fc65ef39ca..8c1b437c5403 100644
> --- a/fs/nfs/nfs3client.c
> +++ b/fs/nfs/nfs3client.c
> @@ -1,6 +1,7 @@
> #include <linux/nfs_fs.h>
> #include <linux/nfs_mount.h>
> #include "internal.h"
> +#include "nfs3_fs.h"
>
> #ifdef CONFIG_NFS_V3_ACL
> static struct rpc_stat nfsacl_rpcstat = { &nfsacl_program };
>