2016-04-29 13:26:08

by Scott Mayhew

Subject: [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname()

If we fall back to using the numeric host then we shouldn't call
xlog with D_GENERAL. That can cause 'exportfs -u' to exit with a 1
if, for example, you have exports using ip addresses that can't be
resolved to hostnames. Use D_PARSE instead.

Signed-off-by: Scott Mayhew <[email protected]>
---
support/export/hostname.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/export/hostname.c b/support/export/hostname.c
index 94e98a5..5c4c824 100644
--- a/support/export/hostname.c
+++ b/support/export/hostname.c
@@ -230,7 +230,7 @@ host_canonname(const struct sockaddr *sap)
default:
(void)getnameinfo(sap, salen, buf, (socklen_t)sizeof(buf),
NULL, 0, NI_NUMERICHOST);
- xlog(D_GENERAL, "%s: failed to resolve %s: %s",
+ xlog(D_PARSE, "%s: failed to resolve %s: %s",
__func__, buf, gai_strerror(error));
return NULL;
}
--
2.4.11

2016-05-02 15:58:35

by Steve Dickson

Subject: Re: [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname()

On 04/29/2016 09:26 AM, Scott Mayhew wrote:
> If we fall back to using the numeric host then we shouldn't call
> xlog with D_GENERAL. That can cause 'exportfs -u' to exit with a 1
> if, for example, you have exports using ip addresses that can't be
> resolved to hostnames. Use D_PARSE instead.
>
> Signed-off-by: Scott Mayhew <[email protected]>
Committed...

steved.

> ---
> support/export/hostname.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index 94e98a5..5c4c824 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -230,7 +230,7 @@ host_canonname(const struct sockaddr *sap)
> default:
> (void)getnameinfo(sap, salen, buf, (socklen_t)sizeof(buf),
> NULL, 0, NI_NUMERICHOST);
> - xlog(D_GENERAL, "%s: failed to resolve %s: %s",
> + xlog(D_PARSE, "%s: failed to resolve %s: %s",
> __func__, buf, gai_strerror(error));
> return NULL;
> }
> -- 2.4.11
>