2016-07-08 02:03:44

by Oleg Drokin

Subject: [PATCH] nfsd: Correct a comment for NFSD_MAY_ defines location

Those are now defined in fs/nfsd/vfs.h

Signed-off-by: Oleg Drokin <[email protected]>
---
fs/nfsd/nfsfh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
index a891944..7e49dcb 100644
--- a/fs/nfsd/nfsfh.c
+++ b/fs/nfsd/nfsfh.c
@@ -298,7 +298,7 @@ out:
* that it expects something not of the given type.
*
* @access is formed from the NFSD_MAY_* constants defined in
- * include/linux/nfsd/nfsd.h.
+ * fs/nfsd/vfs.h.
*/
__be32
fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, int access)
--
2.7.4

2016-07-08 10:45:36

by Jeff Layton

Subject: Re: [PATCH] nfsd: Correct a comment for NFSD_MAY_ defines location

On Thu, 2016-07-07 at 21:49 -0400, Oleg Drokin wrote:
> Those are now defined in fs/nfsd/vfs.h
>
> Signed-off-by: Oleg Drokin <[email protected]>
> ---
>  fs/nfsd/nfsfh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index a891944..7e49dcb 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -298,7 +298,7 @@ out:
>   * that it expects something not of the given type.
>   *
>   * @access is formed from the NFSD_MAY_* constants defined in
> - * include/linux/nfsd/nfsd.h.
> + * fs/nfsd/vfs.h.
>   */
>  __be32
>  fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type,
> int access)

Reviewed-by: Jeff Layton <[email protected]>

2016-07-08 20:25:44

by J. Bruce Fields

Subject: Re: [PATCH] nfsd: Correct a comment for NFSD_MAY_ defines location

Thanks, applied.--b.

On Fri, Jul 08, 2016 at 06:45:31AM -0400, Jeff Layton wrote:
> On Thu, 2016-07-07 at 21:49 -0400, Oleg Drokin wrote:
> > Those are now defined in fs/nfsd/vfs.h
> >
> > Signed-off-by: Oleg Drokin <[email protected]>
> > ---
> >  fs/nfsd/nfsfh.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> > index a891944..7e49dcb 100644
> > --- a/fs/nfsd/nfsfh.c
> > +++ b/fs/nfsd/nfsfh.c
> > @@ -298,7 +298,7 @@ out:
> >   * that it expects something not of the given type.
> >   *
> >   * @access is formed from the NFSD_MAY_* constants defined in
> > - * include/linux/nfsd/nfsd.h.
> > + * fs/nfsd/vfs.h.
> >   */
> >  __be32
> >  fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type,
> > int access)
>
> Reviewed-by: Jeff Layton <[email protected]>