2016-07-09 05:15:39

by Jianhong.Yin

Subject: [PATCH] exportfs: fix export point checking

NFS does not support file and symbolic export, if the export point
is regular file should give warning to user.

Signed-off-by: Jianhong Yin <[email protected]>
---
utils/exportfs/exportfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index 5db348b..a00b5ea 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -585,8 +585,8 @@ validate_export(nfs_export *exp)
xlog(L_ERROR, "Failed to stat %s: %m", path);
return;
}
- if (!S_ISDIR(stb.st_mode) && !S_ISREG(stb.st_mode)) {
- xlog(L_ERROR, "%s is neither a directory nor a file. "
+ if (!S_ISDIR(stb.st_mode)) {
+ xlog(L_ERROR, "%s is not a directory. "
"Remote access will fail", path);
return;
}
--
2.5.5

2016-07-18 17:33:10

by Steve Dickson

Subject: Re: [PATCH] exportfs: fix export point checking

On 07/09/2016 01:15 AM, Jianhong.Yin wrote:
> NFS does not support file and symbolic export, if the export point
> is regular file should give warning to user.
>
> Signed-off-by: Jianhong Yin <[email protected]>
> ---
> utils/exportfs/exportfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Committed...

steved.
>
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index 5db348b..a00b5ea 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -585,8 +585,8 @@ validate_export(nfs_export *exp)
> xlog(L_ERROR, "Failed to stat %s: %m", path);
> return;
> }
> - if (!S_ISDIR(stb.st_mode) && !S_ISREG(stb.st_mode)) {
> - xlog(L_ERROR, "%s is neither a directory nor a file. "
> + if (!S_ISDIR(stb.st_mode)) {
> + xlog(L_ERROR, "%s is not a directory. "
> "Remote access will fail", path);
> return;
> }
>