2017-09-13 15:58:35

by Justin Mitchell

[permalink] [raw]
Subject: Re: [PATCH 5/7] nfs-utils: Import libnfsidmap codebase

On Wed, 2017-09-13 at 10:35 -0400, Steve Dickson wrote:
>
> On 09/13/2017 10:04 AM, Justin Mitchell wrote:
> > Merge the libnfsidmap code tree into nfs-utils.
> > These are the original unmodified files, cherry picked only the
> > necessary files that dont duplicate code, so will not build
> > correctly at this stage.
> >
> > Signed-off-by: Justin Mitchell <[email protected]>
> > ---
> > utils/libnfsidmap/AUTHORS | 1 +
> > utils/libnfsidmap/COPYING | 30 +
> > utils/libnfsidmap/Makefile.am | 62 ++
> > utils/libnfsidmap/README | 126 ++++
> > utils/libnfsidmap/gums.c | 788 ++++++++++++++++++++
> > utils/libnfsidmap/idmapd.conf | 137 ++++
> > utils/libnfsidmap/idmapd.conf.5 | 308 ++++++++
> > utils/libnfsidmap/libnfsidmap.c | 709 ++++++++++++++++++
> > utils/libnfsidmap/libnfsidmap.pc.in | 11 +
> > utils/libnfsidmap/libtest.c | 160 ++++
> > utils/libnfsidmap/nfs4_uid_to_name.3 | 174 +++++
> > utils/libnfsidmap/nfsidmap.h | 67 ++
> > utils/libnfsidmap/nfsidmap_internal.h | 72 ++
> > utils/libnfsidmap/nss.c | 468 ++++++++++++
> > utils/libnfsidmap/static.c | 412 +++++++++++
> > utils/libnfsidmap/umich_ldap.c | 1302 +++++++++++++++++++++++++++++++++
> Quickly looking at this... I think the code should
> go under support/nfsidmap since that's where the
> other libraries live... Not sure how difficult it
> will be to change that...
>
> steved.

Okay, thats no problem, will wait and see what other comments there are
before i post the corrected version.

Justin